Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CVar serialization fix #5712

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

CVar serialization fix #5712

wants to merge 3 commits into from

Conversation

metalgearsloth
Copy link
Contributor

Fixes #5711

On my local client it removes net.max_connections, game.hostname, and the admin cvars.

@metalgearsloth
Copy link
Contributor Author

Might stew on this a bit more as we have a lot of server only vars that are being cross-referenced, hmm...

@metalgearsloth
Copy link
Contributor Author

Actually I think this is fine, most of the ones I checked did need to be replicated but the client shouldn't care about saving them (e.g. hostname).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PJB3005 PJB3005 Awaiting requested review from PJB3005 PJB3005 is a code owner

@DrSmugleaf DrSmugleaf Awaiting requested review from DrSmugleaf DrSmugleaf is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

net.max_connections is saved on the client
1 participant
@metalgearsloth