cmake best practices compiler flags

scivision · scivision · commit f5c6c898dc4c · 2021-10-10T23:56:40.000-04:00
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -1,5 +1,8 @@
 name: ci
 
+env:
+  CMAKE_BUILD_TYPE: Release
+
 on:
   push:
     paths-ignore:
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -1,17 +1,15 @@
-cmake_minimum_required(VERSION 3.1)
-if(NOT CMAKE_BUILD_TYPE)
-  set(CMAKE_BUILD_TYPE Release CACHE STRING "Debug or Release")
-endif()
-project(iri90 Fortran)
+cmake_minimum_required(VERSION 3.14...3.21)
+
+project(iri90 LANGUAGES Fortran)
 
 if(CMAKE_Fortran_COMPILER_ID STREQUAL GNU)
-  set(FFLAGS -std=legacy)
+  add_compile_options(-std=legacy)
 endif()
 
 add_subdirectory(src)
 
 # testiri90 is an interactive program, not for CI
 add_executable(testiri90 src/iritest.for)
-target_link_libraries(testiri90 iri90)
+target_link_libraries(testiri90 PRIVATE iri90)
 
 add_executable(iri90_driver src/iri90.f src/iri90_driver.f90)
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
@@ -1,2 +1 @@
 add_library(iri90 iridreg.for iritec.for igrf.for cira.for irifun.for iriflip.for irisub.for)
-target_compile_options(iri90 PRIVATE ${FFLAGS})

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1 @@`
`1`	`1`	`add_library(iri90 iridreg.for iritec.for igrf.for cira.for irifun.for iriflip.for irisub.for)`
`2`		`-target_compile_options(iri90 PRIVATE ${FFLAGS})`