Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Net/utils does not assert that all ReplicatorResults are present #985

Closed
AndrewSisley opened this issue Dec 19, 2022 · 0 comments · Fixed by #989
Closed

Net/utils does not assert that all ReplicatorResults are present #985

AndrewSisley opened this issue Dec 19, 2022 · 0 comments · Fixed by #989
Assignees
@AndrewSisley
Labels
area/testing Related to any test or testing suite bug Something isn't working
Milestone
DefraDB v0.5

Comments

@AndrewSisley
Copy link
Contributor

It only asserts that the individual received result-items are part of the expected set. This causes the tests to pass if they are expecting more results than what was produced.
@AndrewSisley AndrewSisley added bug Something isn't working area/testing Related to any test or testing suite labels Dec 19, 2022
@AndrewSisley AndrewSisley added this to the DefraDB v0.4 milestone Dec 19, 2022
@AndrewSisley AndrewSisley self-assigned this Dec 19, 2022
@AndrewSisley AndrewSisley changed the title Net/utils does not assert that all ReplicatorResult are present Net/utils does not assert that all ReplicatorResults are present Dec 19, 2022
@AndrewSisley AndrewSisley mentioned this issue Dec 21, 2022
Merged
@AndrewSisley AndrewSisley modified the milestones: DefraDB v0.4, DefraDB v0.5 Dec 29, 2022
@AndrewSisley AndrewSisley mentioned this issue Jan 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewSisley AndrewSisley

Labels
area/testing Related to any test or testing suite bug Something isn't working
Projects
None yet
Milestone
DefraDB v0.5
Development

Successfully merging a pull request may close this issue.

fix: Rework the P2P integration tests sourcenetwork/defradb
1 participant
@AndrewSisley