Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GQL Rework: Decouple defra from GQL #905

Closed
AndrewSisley opened this issue Oct 18, 2022 · 2 comments
Closed

GQL Rework: Decouple defra from GQL #905

AndrewSisley opened this issue Oct 18, 2022 · 2 comments
Assignees
@AndrewSisley
Labels
area/parser Related to the parser components area/planner Related to the planner system area/schema Related to the schema system refactor This issue specific to or requires *notable* refactoring of existing codebases and components

Comments

@AndrewSisley
Copy link
Contributor

Part of #903

Collection ABI should not work with GQL. Planner should not touch it either. Needs to become a layer sitting on top of these.

Query return type is technically gql, but as it is just a map I'm happy leaving it as is.

Should solve #566
@AndrewSisley AndrewSisley added area/schema Related to the schema system area/parser Related to the parser components refactor This issue specific to or requires *notable* refactoring of existing codebases and components area/planner Related to the planner system labels Oct 18, 2022
@AndrewSisley AndrewSisley added this to the DefraDB v0.4 milestone Oct 18, 2022
@AndrewSisley AndrewSisley mentioned this issue Oct 18, 2022
Closed
@jsimnz
Copy link
Member

jsimnz commented Oct 18, 2022

Do you have an idea for the ABI design that isn't GQL specific?

@AndrewSisley
Copy link
Contributor Author

roughly, will just be a strongly typed model similar to the mapper/parser types. The parser types will likely be removed (and the parser package parses to the new model instead). Will probably just be a refactored/refined and documented version of the parser stuff

@AndrewSisley AndrewSisley self-assigned this Oct 19, 2022
This was referenced Oct 19, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewSisley AndrewSisley

Labels
area/parser Related to the parser components area/planner Related to the planner system area/schema Related to the schema system refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsimnz @AndrewSisley