Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink aggregate options (limit etc), grouping, and inline array flow #770

Open
Tracked by #28
AndrewSisley opened this issue Aug 31, 2022 · 2 comments
Open
Tracked by #28
Labels
area/query Related to the query component feature New feature or request

Comments

@AndrewSisley
Copy link
Contributor

At the moment limt, filter etc have to be explicitly performed within aggregate nodes. This is due to both inline arrays (no current way to stream their items through nodes, e.g. limit), and because of the way grouping works (single pass).

Have a bit of a think on this and see if we can remove some of this duplication - it will continue to grow as more aggregates get added, and as more options get added to them.

@AndrewSisley AndrewSisley added feature New feature or request area/query Related to the query component labels Aug 31, 2022
@AndrewSisley AndrewSisley self-assigned this Sep 8, 2022
@AndrewSisley AndrewSisley added this to the DefraDB v0.3.1 milestone Sep 8, 2022
@AndrewSisley
Copy link
Contributor Author

Having a look at this for 0.3.1, might descope it again if I think it is too much

@AndrewSisley
Copy link
Contributor Author

I thought about it, is not worth doing this now, especially given that arrays are all read into memory at the moment anyway. Might include additional locally-scoped refactorings with the array-order ticket, but nothing significant for 0.3.1

@AndrewSisley AndrewSisley removed this from the DefraDB v0.3.1 milestone Sep 8, 2022
@AndrewSisley AndrewSisley removed their assignment Sep 14, 2022
@jsimnz jsimnz added this to the DefraDB v0.5 milestone Sep 20, 2022
@jsimnz jsimnz modified the milestones: DefraDB v0.5, DefraDB v0.6 Mar 23, 2023
@fredcarle fredcarle removed this from the DefraDB v0.6 milestone May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/query Related to the query component feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants