test: Add tests for grouping by undefined value #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
area/query
fredcarle
approved these changes
Jun 21, 2022
| @@ -457,3 +457,89 @@ func TestQuerySimpleWithGroupByBooleanThenNumber(t *testing.T) { | |||
|
|
|||
| executeTestCase(t, test) | |||
| } | |||
|
|
|||
| func TestQuerySimpleWithGroupByNumberOnundefined(t *testing.T) { | |||
There was a problem hiding this comment.
Suggested change
| func TestQuerySimpleWithGroupByNumberOnundefined(t *testing.T) { | |
| func TestQuerySimpleWithGroupByNumberOnUndefined(t *testing.T) { |
There was a problem hiding this comment.
my bad, these were sloppy - thanks Fred
- sort out typos/copy-pasta
| executeTestCase(t, test) | ||
| } | ||
|
|
||
| func TestQuerySimpleWithGroupByNumberOnundefinedWithChildren(t *testing.T) { |
There was a problem hiding this comment.
Suggested change
| func TestQuerySimpleWithGroupByNumberOnundefinedWithChildren(t *testing.T) { | |
| func TestQuerySimpleWithGroupByNumberOnUndefinedWithChildren(t *testing.T) { |
|
|
||
| func TestQuerySimpleWithGroupByNumberOnundefinedWithChildren(t *testing.T) { | ||
| test := testUtils.QueryTestCase{ | ||
| Description: "Simple query with group by number, no children, undefined group value", |
There was a problem hiding this comment.
Suggested change
| Description: "Simple query with group by number, no children, undefined group value", | |
| Description: "Simple query with group by number, with children, undefined group value", |
AndrewSisley
force-pushed
the
sisley/test/I409-group-by-nil
branch
from
52e088a to
8bfa6c8
Compare
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
Add tests for grouping by undefined value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #409
Description
Adds tests for grouping by undefined value. Was a bit surprised that this already works, but now we have tests that assert it.
Tasks
Specify the platform(s) on which this was tested: