fix: Treat explicitly set nil values like omitted values #3101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: This is not desirable :)
These are two different bugs, but they are similar and small, so I am being lazy and sorting them out at the same time.
Field values should not behave differently depending on whether they were ommited from the initial create call.
AndrewSisley
added
bug
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3101 +/- ##
===========================================
- Coverage 79.81% 79.73% -0.08%
===========================================
Files 351 351
Lines 27335 27351 +16
===========================================
- Hits 21816 21808 -8
- Misses 3982 3998 +16
- Partials 1537 1545 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
ChrisBQu
pushed a commit
to ChrisBQu/defradb
that referenced
this pull request
Feb 21, 2025
…rk#3101) ## Relevant issue(s) Resolves sourcenetwork#3100 ## Description Treat explicitly set nil values like omitted values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #3100
Description
Treat explicitly set nil values like omitted values.
There were a couple of bugs here, I suggest reviewing commit by commit as the old behaviour was documented before being corrected.