refactor: Change from protobuf to cbor for gRPC #3061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredcarle
added
refactor
fredcarle
force-pushed
the
fredcarle/refactor/3057-protobuf-to-cbor
branch
from
8f0274c to
b5a27ed
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3061 +/- ##
===========================================
- Coverage 79.47% 79.41% -0.06%
===========================================
Files 343 345 +2
Lines 26511 26534 +23
===========================================
+ Hits 21067 21070 +3
- Misses 3934 3945 +11
- Partials 1510 1519 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 15 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
shahzadlone
approved these changes
Sep 24, 2024
islamaliev
reviewed
Sep 24, 2024
| // handleEncryptionMessage handles incoming FetchEncryptionKeyRequest messages from the pubsub network. | ||
| func (s *pubSubService) handleRequestFromPeer(peerID libpeer.ID, topic string, msg []byte) ([]byte, error) { | ||
| req := new(pb.FetchEncryptionKeyRequest) | ||
| if err := proto.Unmarshal(msg, req); err != nil { | ||
| req := new(fetchEncryptionKeyRequest) |
There was a problem hiding this comment.
thought: not very common way of creating a value on heap.
There was a problem hiding this comment.
You know that is your code right 😉
fredcarle
force-pushed
the
fredcarle/refactor/3057-protobuf-to-cbor
branch
from
dc7d230 to
212d1aa
Compare
ChrisBQu
pushed a commit
to ChrisBQu/defradb
that referenced
this pull request
Feb 21, 2025
## Relevant issue(s) Resolves sourcenetwork#3057 ## Description This PR makes the net gRPC server use cbor instead of protobuf. By doing this we remove the protobuf overhead and the related dependencies which will make compilation to wasm simpler and simplify browser support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #3057
Description
This PR makes the net gRPC server use cbor instead of protobuf. By doing this we remove the protobuf overhead and the related dependencies which will make compilation to wasm simpler and simplify browser support.
Tasks
How has this been tested?
make test
Specify the platform(s) on which this was tested: