Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve the broken OpenAPI dependency update (kin-openapi) #2164

Closed
shahzadlone opened this issue Jan 4, 2024 · 1 comment
Closed

Resolve the broken OpenAPI dependency update (kin-openapi) #2164

shahzadlone opened this issue Jan 4, 2024 · 1 comment
Assignees
Labels
area/api Related to the external API component bump Bumped version for something dependencies Related to dependencies deprecate Indicates something is deprecated.
Milestone

Comments

@shahzadlone
Copy link
Member

shahzadlone commented Jan 4, 2024

The dep: github.com/getkin/kin-openapi v0.120.0, Added in: #1960

For the Open API route feature seems to be broken with the new version bump: #2097

Errors:

Error: http/handler_ccip.go:103:20: invalid operation: cannot index ccipPost.Responses (variable of type *openapi3.Responses)
Error: http/handler_ccip.go:120:19: invalid operation: cannot index ccipGet.Responses (variable of type *openapi3.Responses)
Error: http/handler_collection.go:392:36: invalid argument: cannot make openapi3.Responses; type must be slice, map, or channel
Error: http/handler_collection.go:393:28: invalid operation: cannot index collectionCreate.Responses (variable of type *openapi3.Responses)
Error: http/handler_collection.go:394:28: invalid operation: cannot index collectionCreate.Responses (variable of type *openapi3.Responses)
Error: http/handler_collection.go:413:32: invalid operation: cannot index collectionUpdateWith.Responses (variable of type *openapi3.Responses)
Error: http/handler_collection.go:432:32: invalid operation: cannot index collectionDeleteWith.Responses (variable of type *openapi3.Responses)
Error: http/handler_collection.go:450:23: invalid operation: cannot index createIndex.Responses (variable of type *openapi3.Responses)
Error: http/handler_collection.go:465:22: invalid operation: cannot index getIndexes.Responses (variable of type *openapi3.Responses)
Error: http/handler_collection.go:477:29: invalid argument: cannot make openapi3.Responses; type must be slice, map, or channel
Error: http/handler_collection.go:477:29: too many errors

Probably just need to update the API usage according to the new update.

@nasdf Want to take this on? Probably should remove the DO NOT MERGE label on that PR once resolved on that branch.

@shahzadlone shahzadlone added area/api Related to the external API component dependencies Related to dependencies deprecate Indicates something is deprecated. bump Bumped version for something labels Jan 4, 2024
@nasdf
Copy link
Member

nasdf commented Jan 19, 2024

Closed by #2097

@nasdf nasdf closed this as completed Jan 19, 2024
@fredcarle fredcarle added this to the DefraDB v0.10 milestone Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Related to the external API component bump Bumped version for something dependencies Related to dependencies deprecate Indicates something is deprecated.
Projects
None yet
Development

No branches or pull requests

3 participants