Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate new benchmark suite to the CI system #176

Closed
jsimnz opened this issue Feb 4, 2022 · 0 comments · Fixed by #194
Closed

Integrate new benchmark suite to the CI system #176

jsimnz opened this issue Feb 4, 2022 · 0 comments · Fixed by #194
Assignees
@shahzadlone
Labels
ci/build This is issue is about the build or CI system, and the administration of it. perf Performance issue or suggestion
Milestone
DefraDB v0.2.1

Comments

@jsimnz
Copy link
Member

jsimnz commented Feb 4, 2022

Lets start putting some work on this to get accurate history/record of perf over time.

Additionally, we should find a way to run the benchmark CI only if the other checks pass. Since it actually initializes an EC2 instance, theres no point wasting those resources on a build that wont run (either due to build or lint errors)
@jsimnz jsimnz added ci/build This is issue is about the build or CI system, and the administration of it. perf Performance issue or suggestion labels Feb 4, 2022
@shahzadlone shahzadlone linked a pull request Feb 8, 2022 that will close this issue
ci: Add rule to only run benchmark if other check are successful #194
Merged
@jsimnz jsimnz added this to the DefraDB v0.2.1 milestone Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shahzadlone shahzadlone

Labels
ci/build This is issue is about the build or CI system, and the administration of it. perf Performance issue or suggestion
Projects
None yet
Milestone
DefraDB v0.2.1
Development

Successfully merging a pull request may close this issue.

ci: Add rule to only run benchmark if other check are successful sourcenetwork/defradb
2 participants
@jsimnz @shahzadlone