Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collection_get.go.get only Closes doc fetcher if there are no errors #171

Closed
AndrewSisley opened this issue Feb 2, 2022 · 0 comments · Fixed by #210
Closed

collection_get.go.get only Closes doc fetcher if there are no errors #171

AndrewSisley opened this issue Feb 2, 2022 · 0 comments · Fixed by #210
Assignees
@AndrewSisley
Labels
area/collections Related to the collections system bug Something isn't working
Milestone
DefraDB v0.2.1

Comments

@AndrewSisley
Copy link
Contributor

John spotted it in an unrelated PR and pointed out that is should probably be a defer defined earlier in the function (so it gets run even if there is an error). Change and test
@AndrewSisley AndrewSisley added bug Something isn't working area/collections Related to the collections system labels Feb 2, 2022
@AndrewSisley AndrewSisley mentioned this issue Feb 2, 2022
Merged
@jsimnz jsimnz added this to the DefraDB v0.2.1 milestone Feb 8, 2022
@AndrewSisley AndrewSisley self-assigned this Feb 14, 2022
@AndrewSisley AndrewSisley mentioned this issue Feb 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewSisley AndrewSisley

Labels
area/collections Related to the collections system bug Something isn't working
Projects
None yet
Milestone
DefraDB v0.2.1
Development

Successfully merging a pull request may close this issue.

fix: Close fetcher on error sourcenetwork/defradb
2 participants
@jsimnz @AndrewSisley