Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace reflect.DeepEqual with something nicer #1606

Open
AndrewSisley opened this issue Jul 4, 2023 · 0 comments
Open

Replace reflect.DeepEqual with something nicer #1606

AndrewSisley opened this issue Jul 4, 2023 · 0 comments
Labels
code quality Related to improving code quality

Comments

@AndrewSisley
Copy link
Contributor

We use this in lens/fetcher at the moment. It is pretty unperformant, and may be a nuisance when we come to make defra wasm-compilable.

There may be other places in Defra where we can use this function - have a look and see if we can do a bit of deduplication too.
@AndrewSisley AndrewSisley added the code quality Related to improving code quality label Jul 4, 2023
@AndrewSisley AndrewSisley mentioned this issue Jul 4, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Related to improving code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AndrewSisley