Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relationship is incorrectly joined when both fields share same name #107

Closed
AndrewSisley opened this issue Jan 10, 2022 · 0 comments · Fixed by #109
Closed

Relationship is incorrectly joined when both fields share same name #107

AndrewSisley opened this issue Jan 10, 2022 · 0 comments · Fixed by #109
Assignees
@AndrewSisley
Labels
area/collections Related to the collections system bug Something isn't working

Comments

@AndrewSisley
Copy link
Contributor

For example, querying the below schema will fail ~50% of the time as it incorrectly labels the join direction:

type book {
  name: String
  sameName: author
}

type author {
  name: String
  sameName: [book]
}

Bug is in descriptions.go/relations.go GetField function
@AndrewSisley AndrewSisley added the bug Something isn't working label Jan 10, 2022
@AndrewSisley AndrewSisley self-assigned this Jan 10, 2022
@AndrewSisley AndrewSisley added the area/collections Related to the collections system label Jan 10, 2022
@AndrewSisley AndrewSisley mentioned this issue Jan 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewSisley AndrewSisley

Labels
area/collections Related to the collections system bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Support relationships where both fields have the same name sourcenetwork/defradb
1 participant
@AndrewSisley