Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow getting collection by version id #1007

Closed
Tracked by #1002
AndrewSisley opened this issue Dec 30, 2022 · 2 comments
Closed
Tracked by #1002

Allow getting collection by version id #1007

AndrewSisley opened this issue Dec 30, 2022 · 2 comments
Labels
area/collections Related to the collections system area/schema Related to the schema system feature New feature or request

Comments

@AndrewSisley
Copy link
Contributor

AndrewSisley commented Dec 30, 2022 •
edited
Loading

E.g. fetch user schema at version 5. Should probably return a collection object (with a new version identifier - note there is already a prop on SchemaDescription: Key for this purpose, it is dead code but either use it or remove it)
@AndrewSisley AndrewSisley added feature New feature or request area/schema Related to the schema system area/collections Related to the collections system labels Dec 30, 2022
@AndrewSisley AndrewSisley added this to the DefraDB v0.5 milestone Dec 30, 2022
This was referenced Dec 30, 2022
Open
Open
@AndrewSisley
Copy link
Contributor Author

There are a couple of refactorings that can be done with this ticket.

  • planner/datasource.go/getCollectionDesc
  • planner/mapper.go/getCollectionDesc
  • also ofc the main db.GetCollectionByX funcs

See also #1026 (comment)

@jsimnz jsimnz modified the milestones: DefraDB v0.5, DefraDB v0.5.1 Mar 23, 2023
@AndrewSisley AndrewSisley mentioned this issue Mar 27, 2023
Merged
4 tasks
@fredcarle fredcarle modified the milestones: DefraDB v0.6, DefraDB v0.7 Jul 4, 2023
@fredcarle fredcarle modified the milestones: DefraDB v0.7, DefraDB v0.8 Jul 31, 2023
@AndrewSisley AndrewSisley removed this from the DefraDB v0.8 milestone Sep 15, 2023
@AndrewSisley
Copy link
Contributor Author

This has been done

@AndrewSisley AndrewSisley changed the title Allow versioned querying of schema/collections Allow getting collection by version id Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/collections Related to the collections system area/schema Related to the schema system feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jsimnz @fredcarle @AndrewSisley