Skip to content
This repository was archived by the owner on Nov 6, 2018. It is now read-only.

Commit e480b69

Browse files
sqssqs
committed
fix: use strict assertion methods
1 parent 9d6904e commit e480b69

File tree

3 files changed

+50
-50
lines changed

3 files changed

+50
-50
lines changed

‎src/types/common.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@ import assert from 'assert'
33
export function assertToJSON(a: any, expected: any): void {
44
const raw = JSON.stringify(a)
55
const actual = JSON.parse(raw)
6-
assert.deepEqual(actual, expected)
6+
assert.deepStrictEqual(actual, expected)
77
}

‎src/types/position.test.ts

+19-19
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ describe('Position', () => {
1313
assert.throws(() => ((pos as any).line = 12))
1414

1515
const { line, character } = pos.toJSON()
16-
assert.equal(line, 0)
17-
assert.equal(character, 0)
16+
assert.strictEqual(line, 0)
17+
assert.strictEqual(character, 0)
1818
})
1919

2020
it('toJSON', () => {
@@ -50,11 +50,11 @@ describe('Position', () => {
5050
const p2 = new Position(1, 2)
5151
const p3 = new Position(0, 4)
5252

53-
assert.equal(p1.compareTo(p1), 0)
54-
assert.equal(p2.compareTo(p1), -1)
55-
assert.equal(p1.compareTo(p2), 1)
56-
assert.equal(p2.compareTo(p3), 1)
57-
assert.equal(p1.compareTo(p3), 1)
53+
assert.strictEqual(p1.compareTo(p1), 0)
54+
assert.strictEqual(p2.compareTo(p1), -1)
55+
assert.strictEqual(p1.compareTo(p2), 1)
56+
assert.strictEqual(p2.compareTo(p3), 1)
57+
assert.strictEqual(p1.compareTo(p3), 1)
5858
})
5959

6060
it('translate', () => {
@@ -68,24 +68,24 @@ describe('Position', () => {
6868
assert.ok(p1.translate(undefined) === p1)
6969

7070
let res = p1.translate(-1)
71-
assert.equal(res.line, 0)
72-
assert.equal(res.character, 3)
71+
assert.strictEqual(res.line, 0)
72+
assert.strictEqual(res.character, 3)
7373

7474
res = p1.translate({ lineDelta: -1 })
75-
assert.equal(res.line, 0)
76-
assert.equal(res.character, 3)
75+
assert.strictEqual(res.line, 0)
76+
assert.strictEqual(res.character, 3)
7777

7878
res = p1.translate(undefined, -1)
79-
assert.equal(res.line, 1)
80-
assert.equal(res.character, 2)
79+
assert.strictEqual(res.line, 1)
80+
assert.strictEqual(res.character, 2)
8181

8282
res = p1.translate({ characterDelta: -1 })
83-
assert.equal(res.line, 1)
84-
assert.equal(res.character, 2)
83+
assert.strictEqual(res.line, 1)
84+
assert.strictEqual(res.character, 2)
8585

8686
res = p1.translate(11)
87-
assert.equal(res.line, 12)
88-
assert.equal(res.character, 3)
87+
assert.strictEqual(res.line, 12)
88+
assert.strictEqual(res.character, 3)
8989

9090
assert.throws(() => p1.translate(null as any))
9191
assert.throws(() => p1.translate(null as any, null as any))
@@ -108,8 +108,8 @@ describe('Position', () => {
108108
assert.ok(p1.with({ line: 1, character: 3 }) === p1)
109109

110110
const p2 = p1.with({ line: 0, character: 11 })
111-
assert.equal(p2.line, 0)
112-
assert.equal(p2.character, 11)
111+
assert.strictEqual(p2.line, 0)
112+
assert.strictEqual(p2.character, 11)
113113

114114
assert.throws(() => p1.with(null as any))
115115
assert.throws(() => p1.with(-9))

‎src/types/range.test.ts

+30-30
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,12 @@ describe('Range', () => {
3030
it('sorting', () => {
3131
// sorts start/end
3232
let range = new Range(1, 0, 0, 0)
33-
assert.equal(range.start.line, 0)
34-
assert.equal(range.end.line, 1)
33+
assert.strictEqual(range.start.line, 0)
34+
assert.strictEqual(range.end.line, 1)
3535

3636
range = new Range(0, 0, 1, 0)
37-
assert.equal(range.start.line, 0)
38-
assert.equal(range.end.line, 1)
37+
assert.strictEqual(range.start.line, 0)
38+
assert.strictEqual(range.end.line, 1)
3939
})
4040

4141
it('isEmpty|isSingleLine', () => {
@@ -74,26 +74,26 @@ describe('Range', () => {
7474
let res: sourcegraph.Range | undefined
7575

7676
res = range.intersection(range)
77-
assert.equal(res && res.start.line, 1)
78-
assert.equal(res && res.start.character, 1)
79-
assert.equal(res && res.end.line, 2)
80-
assert.equal(res && res.end.character, 11)
77+
assert.strictEqual(res && res.start.line, 1)
78+
assert.strictEqual(res && res.start.character, 1)
79+
assert.strictEqual(res && res.end.line, 2)
80+
assert.strictEqual(res && res.end.character, 11)
8181

8282
res = range.intersection(new Range(2, 12, 4, 0))
83-
assert.equal(res, undefined)
83+
assert.strictEqual(res, undefined)
8484

8585
res = range.intersection(new Range(0, 0, 1, 0))
86-
assert.equal(res, undefined)
86+
assert.strictEqual(res, undefined)
8787

8888
res = range.intersection(new Range(0, 0, 1, 1))
8989
assert.ok(res && res.isEmpty)
90-
assert.equal(res && res.start.line, 1)
91-
assert.equal(res && res.start.character, 1)
90+
assert.strictEqual(res && res.start.line, 1)
91+
assert.strictEqual(res && res.start.character, 1)
9292

9393
res = range.intersection(new Range(2, 11, 61, 1))
9494
assert.ok(res && res.isEmpty)
95-
assert.equal(res && res.start.line, 2)
96-
assert.equal(res && res.start.character, 11)
95+
assert.strictEqual(res && res.start.line, 2)
96+
assert.strictEqual(res && res.start.character, 11)
9797

9898
assert.throws(() => range.intersection(null as any))
9999
assert.throws(() => range.intersection(undefined as any))
@@ -106,14 +106,14 @@ describe('Range', () => {
106106
let res: sourcegraph.Range
107107
res = ran1.union(new Range(2, 2, 9, 9))
108108
assert.ok(res.start === ran1.start)
109-
assert.equal(res.end.line, 9)
110-
assert.equal(res.end.character, 9)
109+
assert.strictEqual(res.end.line, 9)
110+
assert.strictEqual(res.end.character, 9)
111111

112112
ran1 = new Range(2, 1, 5, 3)
113113
res = ran1.union(new Range(1, 0, 4, 2))
114114
assert.ok(res.end === ran1.end)
115-
assert.equal(res.start.line, 1)
116-
assert.equal(res.start.character, 0)
115+
assert.strictEqual(res.start.line, 1)
116+
assert.strictEqual(res.start.character, 0)
117117
})
118118

119119
it('with', () => {
@@ -131,22 +131,22 @@ describe('Range', () => {
131131
assert.ok(range.with({ end: new Position(2, 11) }) === range)
132132

133133
let res = range.with(undefined, new Position(9, 8))
134-
assert.equal(res.end.line, 9)
135-
assert.equal(res.end.character, 8)
136-
assert.equal(res.start.line, 1)
137-
assert.equal(res.start.character, 1)
134+
assert.strictEqual(res.end.line, 9)
135+
assert.strictEqual(res.end.character, 8)
136+
assert.strictEqual(res.start.line, 1)
137+
assert.strictEqual(res.start.character, 1)
138138

139139
res = range.with({ end: new Position(9, 8) })
140-
assert.equal(res.end.line, 9)
141-
assert.equal(res.end.character, 8)
142-
assert.equal(res.start.line, 1)
143-
assert.equal(res.start.character, 1)
140+
assert.strictEqual(res.end.line, 9)
141+
assert.strictEqual(res.end.character, 8)
142+
assert.strictEqual(res.start.line, 1)
143+
assert.strictEqual(res.start.character, 1)
144144

145145
res = range.with({ end: new Position(9, 8), start: new Position(2, 3) })
146-
assert.equal(res.end.line, 9)
147-
assert.equal(res.end.character, 8)
148-
assert.equal(res.start.line, 2)
149-
assert.equal(res.start.character, 3)
146+
assert.strictEqual(res.end.line, 9)
147+
assert.strictEqual(res.end.character, 8)
148+
assert.strictEqual(res.start.line, 2)
149+
assert.strictEqual(res.start.character, 3)
150150

151151
assert.throws(() => range.with(null as any))
152152
assert.throws(() => range.with(undefined, null as any))

0 commit comments

Comments
 (0)