Skip to content
This repository was archived by the owner on Nov 6, 2018. It is now read-only.

Commit 5b58136

Browse files
committed
fix: support undefined in hover response per ProviderResult
1 parent 7911fca commit 5b58136

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/client/providers/hover.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@ import { TextDocumentPositionParams, TextDocumentRegistrationOptions } from '../
55
import { Hover } from '../../protocol/plainTypes'
66
import { FeatureProviderRegistry } from './registry'
77

8-
export type ProvideTextDocumentHoverSignature = (params: TextDocumentPositionParams) => Observable<Hover | null>
8+
export type ProvideTextDocumentHoverSignature = (
9+
params: TextDocumentPositionParams
10+
) => Observable<Hover | null | undefined>
911

1012
/** Provides hovers from all extensions. */
1113
export class TextDocumentHoverProviderRegistry extends FeatureProviderRegistry<

src/client/types/hover.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export interface HoverMerged {
99

1010
export namespace HoverMerged {
1111
/** Create a merged hover from the given individual hovers. */
12-
export function from(values: (Hover | PlainHover | null)[]): HoverMerged | null {
12+
export function from(values: (Hover | PlainHover | null | undefined)[]): HoverMerged | null {
1313
const contents: HoverMerged['contents'] = []
1414
let range: HoverMerged['range']
1515
for (const result of values) {

0 commit comments

Comments
 (0)