Skip to content
This repository was archived by the owner on Nov 6, 2018. It is now read-only.

Commit df221a5

Browse files
committed
refactor: make most names singular to be consistent
BREAKING CHANGE: Many files (modules) changed names to be singular, not plural.
1 parent f63b822 commit df221a5

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+66
-66
lines changed

examples/client/config.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { DocumentSelector } from '../../src/types/documents'
1+
import { DocumentSelector } from '../../src/types/document'
22

33
export default require('./package.json').cxp as {
44
url: string

examples/client/example-client-simple.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import * as NodeWebSocket from 'ws'
22
import { createMessageConnection } from '../../src/jsonrpc2/connection'
33
import { createWebSocketMessageTransports } from '../../src/jsonrpc2/transports/nodeWebSocket'
44
import { InitializeParams, InitializeRequest, InitializeResult } from '../../src/protocol'
5-
import { TextDocumentDecorationsParams, TextDocumentDecorationsRequest } from '../../src/protocol/decorations'
5+
import { TextDocumentDecorationsParams, TextDocumentDecorationsRequest } from '../../src/protocol/decoration'
66
import config from './config'
77

88
async function run(): Promise<void> {

examples/client/example-client.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@ import { BehaviorSubject } from 'rxjs'
22
import { filter } from 'rxjs/operators'
33
import * as WebSocket from 'ws'
44
import { Client, ClientState } from '../../src/client/client'
5-
import { TextDocumentStaticDecorationsFeature } from '../../src/client/features/decorations'
5+
import { TextDocumentStaticDecorationsFeature } from '../../src/client/features/decoration'
66
import { TextDocumentHoverFeature } from '../../src/client/features/hover'
7-
import { TextDocumentDidOpenFeature } from '../../src/client/features/textDocuments'
7+
import { TextDocumentDidOpenFeature } from '../../src/client/features/textDocument'
88
import { createObservableEnvironment, EMPTY_ENVIRONMENT, Environment } from '../../src/environment/environment'
99
import { NoopProviderRegistry } from '../../src/environment/providers/textDocument'
1010
import { createWebSocketMessageTransports } from '../../src/jsonrpc2/transports/nodeWebSocket'
11-
import { TextDocumentDecorationsParams, TextDocumentDecorationsRequest } from '../../src/protocol/decorations'
11+
import { TextDocumentDecorationsParams, TextDocumentDecorationsRequest } from '../../src/protocol/decoration'
1212
import config from './config'
1313

1414
const environment = new BehaviorSubject<Environment>(EMPTY_ENVIRONMENT)

examples/server/example-server-node.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import * as WebSocket from 'ws'
44
import { createWebSocketMessageTransports } from '../../src/jsonrpc2/transports/nodeWebSocket'
55
import { StreamMessageReader, StreamMessageWriter } from '../../src/jsonrpc2/transports/stream'
66
import { InitializeResult } from '../../src/protocol'
7-
import { TextDocumentDecoration, TextDocumentDecorationsParams } from '../../src/protocol/decorations'
7+
import { TextDocumentDecoration, TextDocumentDecorationsParams } from '../../src/protocol/decoration'
88
import { Connection, createConnection } from '../../src/server/server'
99

1010
function register(connection: Connection): void {

examples/server/example-server-webworker.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { createWebWorkerMessageTransports, Worker } from '../../src/jsonrpc2/transports/webWorker'
22
import { InitializeResult } from '../../src/protocol'
3-
import { TextDocumentDecoration, TextDocumentDecorationsParams } from '../../src/protocol/decorations'
3+
import { TextDocumentDecoration, TextDocumentDecorationsParams } from '../../src/protocol/decoration'
44
import { Connection, createConnection } from '../../src/server/server'
55

66
declare var self: Worker

src/client/client.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import {
2222
UnregistrationParams,
2323
UnregistrationRequest,
2424
} from '../protocol'
25-
import { DocumentSelector } from '../types/documents'
25+
import { DocumentSelector } from '../types/document'
2626
import { URI } from '../types/textDocument'
2727
import { isFunction } from '../util'
2828
import { Connection, createConnection } from './connection'
File renamed without changes.

src/client/features/common.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
ServerCapabilities,
77
TextDocumentRegistrationOptions,
88
} from '../../protocol'
9-
import { DocumentSelector } from '../../types/documents'
9+
import { DocumentSelector } from '../../types/document'
1010
import { isFunction } from '../../util'
1111
import { Client } from '../client'
1212

src/client/features/configuration.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import { DynamicFeature, ensure, RegistrationData, StaticFeature } from './commo
2020
* Support for extension settings managed by the client (workspace/didChangeConfiguration notifications to the
2121
* server).
2222
*/
23-
export class ConfigurationChangeNotificationsFeature implements DynamicFeature<undefined> {
23+
export class ConfigurationChangeNotificationFeature implements DynamicFeature<undefined> {
2424
private subscriptions = new Subscription()
2525
private listener: Subscription | null = null
2626

src/client/features/decorations.ts src/client/features/decoration.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ import {
1010
TextDocumentDecorationsRequest,
1111
TextDocumentPublishDecorationsNotification,
1212
TextDocumentPublishDecorationsParams,
13-
} from '../../protocol/decorations'
14-
import { DocumentSelector } from '../../types/documents'
13+
} from '../../protocol/decoration'
14+
import { DocumentSelector } from '../../types/document'
1515
import { NextSignature } from '../../types/middleware'
1616
import { Client } from '../client'
1717
import { ensure, TextDocumentFeature } from './common'

src/client/features/hover.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {
1010
TextDocumentPositionParams,
1111
TextDocumentRegistrationOptions,
1212
} from '../../protocol'
13-
import { DocumentSelector } from '../../types/documents'
13+
import { DocumentSelector } from '../../types/document'
1414
import { NextSignature } from '../../types/middleware'
1515
import { Client } from '../client'
1616
import { ensure, TextDocumentFeature } from './common'

src/client/features/logMessages.ts src/client/features/logMessage.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { StaticFeature } from './common'
55
/**
66
* Support for server log messages (window/logMessage notifications from the server).
77
*/
8-
export class WindowLogMessagesFeature implements StaticFeature {
8+
export class WindowLogMessageFeature implements StaticFeature {
99
constructor(
1010
private client: Client,
1111
/** Called when the client receives a window/logMessage notification. */

src/client/features/showMessages.ts src/client/features/message.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import { StaticFeature } from './common'
1212
* Support for server messages intended for display to the user (window/showMessages notifications and
1313
* window/showMessageRequest requests from the server).
1414
*/
15-
export class WindowShowMessagesFeature implements StaticFeature {
15+
export class WindowShowMessageFeature implements StaticFeature {
1616
constructor(
1717
private client: Client,
1818
/** Called when the client receives a window/showMessage notification. */

src/client/features/textDocuments.ts src/client/features/textDocument.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {
1010
ServerCapabilities,
1111
TextDocumentRegistrationOptions,
1212
} from '../../protocol'
13-
import { DocumentSelector } from '../../types/documents'
13+
import { DocumentSelector } from '../../types/document'
1414
import { NextSignature } from '../../types/middleware'
1515
import { match } from '../../types/textDocument'
1616
import { Client } from '../client'

src/client/middleware.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { NextSignature } from '../types/middleware'
33
import {
44
HandleTextDocumentDecorationsMiddleware,
55
ProvideTextDocumentDecorationsMiddleware,
6-
} from './features/decorations'
6+
} from './features/decoration'
77
import { ProvideTextDocumentHoverMiddleware } from './features/hover'
88

99
export interface Middleware {

src/client/validator.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import * as assert from 'assert'
22
import { Position, Range } from 'vscode-languageserver-types'
3-
import { TextDocumentDecoration } from '../protocol/decorations'
3+
import { TextDocumentDecoration } from '../protocol/decoration'
44
import { createValidator } from './validator'
55

66
const validator = createValidator()

src/client/validator.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { TextDocumentDecoration } from '../protocol/decorations'
1+
import { TextDocumentDecoration } from '../protocol/decoration'
22

33
export interface Validator {
44
asTextDocumentDecoration(value: TextDocumentDecoration): TextDocumentDecoration

src/environment/controller.ts

+9-9
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,20 @@
11
import { BehaviorSubject, Observable, Subject, Subscription, SubscriptionLike, Unsubscribable } from 'rxjs'
22
import { distinctUntilChanged, filter, map } from 'rxjs/operators'
33
import { Client, ClientOptions } from '../client/client'
4-
import { ExecuteCommandFeature } from '../client/features/commands'
4+
import { ExecuteCommandFeature } from '../client/features/command'
55
import {
6-
ConfigurationChangeNotificationsFeature,
6+
ConfigurationChangeNotificationFeature,
77
ConfigurationFeature,
88
ConfigurationUpdateFeature,
99
} from '../client/features/configuration'
1010
import {
1111
TextDocumentDynamicDecorationsFeature,
1212
TextDocumentStaticDecorationsFeature,
13-
} from '../client/features/decorations'
13+
} from '../client/features/decoration'
1414
import { TextDocumentHoverFeature } from '../client/features/hover'
15-
import { WindowLogMessagesFeature } from '../client/features/logMessages'
16-
import { WindowShowMessagesFeature } from '../client/features/showMessages'
17-
import { TextDocumentDidOpenFeature } from '../client/features/textDocuments'
15+
import { WindowLogMessageFeature } from '../client/features/logMessage'
16+
import { WindowShowMessageFeature } from '../client/features/message'
17+
import { TextDocumentDidOpenFeature } from '../client/features/textDocument'
1818
import { MessageTransports } from '../jsonrpc2/connection'
1919
import { Trace } from '../jsonrpc2/trace'
2020
import {
@@ -164,7 +164,7 @@ export class Controller<X extends Extension = Extension> implements Unsubscribab
164164
}
165165

166166
private registerClientFeatures(client: Client, settings: Observable<ExtensionSettings>): void {
167-
client.registerFeature(new ConfigurationChangeNotificationsFeature(client, settings))
167+
client.registerFeature(new ConfigurationChangeNotificationFeature(client, settings))
168168
client.registerFeature(new ConfigurationFeature(client, settings))
169169
client.registerFeature(
170170
new ConfigurationUpdateFeature(
@@ -185,12 +185,12 @@ export class Controller<X extends Extension = Extension> implements Unsubscribab
185185
new TextDocumentDynamicDecorationsFeature(client, this.registries.textDocumentDecorations)
186186
)
187187
client.registerFeature(
188-
new WindowLogMessagesFeature(client, (params: LogMessageParams) =>
188+
new WindowLogMessageFeature(client, (params: LogMessageParams) =>
189189
this._logMessages.next({ ...params, extension: client.id })
190190
)
191191
)
192192
client.registerFeature(
193-
new WindowShowMessagesFeature(
193+
new WindowShowMessageFeature(
194194
client,
195195
(params: ShowMessageParams) => this._showMessages.next({ ...params, extension: client.id }),
196196
(params: ShowMessageRequestParams) =>

src/environment/providers/decoration.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { combineLatest, Observable } from 'rxjs'
22
import { catchError, map, switchMap } from 'rxjs/operators'
33
import { TextDocumentRegistrationOptions } from '../../protocol'
4-
import { TextDocumentDecoration, TextDocumentDecorationsParams } from '../../protocol/decorations'
4+
import { TextDocumentDecoration, TextDocumentDecorationsParams } from '../../protocol/decoration'
55
import { compact, flatten } from '../../util'
66
import { TextDocumentFeatureProviderRegistry } from './textDocument'
77

src/environment/registries.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { CommandRegistry } from '../client/features/commands'
1+
import { CommandRegistry } from '../client/features/command'
22
import { TextDocumentDecorationsProviderRegistry } from './providers/decoration'
33
import { TextDocumentHoverProviderRegistry } from './providers/hover'
44

src/jsonrpc2/connection.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ import {
2828
ResponseMessage,
2929
} from './messages'
3030
import { LogTraceNotification, SetTraceNotification, Trace, Tracer } from './trace'
31-
import { DataCallback, MessageReader, MessageWriter } from './transports'
31+
import { DataCallback, MessageReader, MessageWriter } from './transport'
3232

3333
// Copied from vscode-languageserver to avoid adding extraneous dependencies.
3434

src/jsonrpc2/transports.ts src/jsonrpc2/transport.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import { Emitter, Event } from '../jsonrpc2/events'
2-
import { Message } from '../jsonrpc2/messages'
31
import { isFunction } from '../util'
2+
import { Emitter, Event } from './events'
3+
import { Message } from './messages'
44

55
// Copied from vscode-jsonrpc to avoid adding extraneous dependencies.
66

src/jsonrpc2/transports/browserWebSocket.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { MessageTransports } from '../connection'
22
import { Message } from '../messages'
3-
import { AbstractMessageReader, AbstractMessageWriter, DataCallback, MessageReader, MessageWriter } from '../transports'
3+
import { AbstractMessageReader, AbstractMessageWriter, DataCallback, MessageReader, MessageWriter } from '../transport'
44

55
// Copied subset of WebSocket from the TypeScript "dom" core library to avoid needing to add that lib to
66
// tsconfig.json.

src/jsonrpc2/transports/nodeWebSocket.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import * as NodeWebSocket from 'ws'
22
import { MessageTransports } from '../connection'
33
import { Message } from '../messages'
4-
import { AbstractMessageReader, AbstractMessageWriter, DataCallback, MessageReader, MessageWriter } from '../transports'
4+
import { AbstractMessageReader, AbstractMessageWriter, DataCallback, MessageReader, MessageWriter } from '../transport'
55

66
class WebSocketMessageReader extends AbstractMessageReader implements MessageReader {
77
private pending: Message[] = []

src/jsonrpc2/transports/socket.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { Socket } from 'net'
22
import { Message } from '../messages'
3-
import { AbstractMessageWriter, MessageWriter } from '../transports'
3+
import { AbstractMessageWriter, MessageWriter } from '../transport'
44
import { ContentLength, CRLF, StreamMessageReader } from './stream'
55

66
export class SocketMessageReader extends StreamMessageReader {

src/jsonrpc2/transports/stream.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { Message } from '../messages'
2-
import { AbstractMessageReader, AbstractMessageWriter, DataCallback, MessageReader, MessageWriter } from '../transports'
2+
import { AbstractMessageReader, AbstractMessageWriter, DataCallback, MessageReader, MessageWriter } from '../transport'
33

44
const DefaultSize = 8192
55
const CR: number = Buffer.from('\r', 'ascii')[0]

src/jsonrpc2/transports/webWorker.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { MessageTransports } from '../connection'
22
import { Message } from '../messages'
3-
import { AbstractMessageReader, AbstractMessageWriter, DataCallback, MessageReader, MessageWriter } from '../transports'
3+
import { AbstractMessageReader, AbstractMessageWriter, DataCallback, MessageReader, MessageWriter } from '../transport'
44

55
// TODO: use transferable objects in postMessage for perf
66

src/protocol/capabilities.ts

+8-8
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
import { CodeLensOptions } from './codeLens'
2-
import { ColorClientCapabilities, ColorServerCapabilities } from './colors'
3-
import { ExecuteCommandOptions } from './commands'
2+
import { ColorClientCapabilities, ColorServerCapabilities } from './color'
3+
import { ExecuteCommandOptions } from './command'
44
import { CompletionOptions } from './completion'
55
import { ConfigurationClientCapabilities } from './configuration'
6-
import { ContributionsClientCapabilities, ContributionsServerCapabilities } from './contributions'
7-
import { DecorationsClientCapabilities, DecorationsServerCapabilities } from './decorations'
8-
import { DocumentLinkOptions } from './documentLinks'
9-
import { ImplementationClientCapabilities, ImplementationServerCapabilities } from './implementations'
6+
import { ContributionsClientCapabilities, ContributionsServerCapabilities } from './contribution'
7+
import { DecorationsClientCapabilities, DecorationsServerCapabilities } from './decoration'
8+
import { DocumentLinkOptions } from './documentLink'
9+
import { ImplementationClientCapabilities, ImplementationServerCapabilities } from './implementation'
1010
import { SignatureHelpOptions } from './signatureHelp'
1111
import { TextDocumentClientCapabilities, TextDocumentSyncKind, TextDocumentSyncOptions } from './textDocument'
12-
import { TypeDefinitionClientCapabilities, TypeDefinitionServerCapabilities } from './typeDefinitions'
12+
import { TypeDefinitionClientCapabilities, TypeDefinitionServerCapabilities } from './typeDefinition'
1313
import { WorkspaceClientCapabilities } from './workspace'
14-
import { WorkspaceFoldersClientCapabilities, WorkspaceFoldersServerCapabilities } from './workspaceFolders'
14+
import { WorkspaceFoldersClientCapabilities, WorkspaceFoldersServerCapabilities } from './workspaceFolder'
1515

1616
/**
1717
* Defines the capabilities provided by the client.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

src/protocol/index.ts

+17-17
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,30 @@
11
export * from './capabilities'
2-
export * from './codeActions'
2+
export * from './codeAction'
33
export * from './codeLens'
4-
export * from './colors'
5-
export * from './commands'
4+
export * from './color'
5+
export * from './command'
66
export * from './completion'
77
export * from './configuration'
8-
export * from './contributions'
9-
export * from './decorations'
10-
export * from './definitions'
11-
export * from './diagnostics'
12-
export * from './documentHighlights'
13-
export * from './documentLinks'
14-
export * from './edits'
15-
export * from './files'
8+
export * from './contribution'
9+
export * from './decoration'
10+
export * from './definition'
11+
export * from './diagnostic'
12+
export * from './documentHighlight'
13+
export * from './documentLink'
14+
export * from './edit'
15+
export * from './file'
1616
export * from './formatting'
1717
export * from './hover'
18-
export * from './implementations'
18+
export * from './implementation'
1919
export * from './initialize'
20-
export * from './messages'
21-
export * from './references'
20+
export * from './message'
21+
export * from './reference'
2222
export * from './registration'
2323
export * from './rename'
2424
export * from './signatureHelp'
25-
export * from './symbols'
25+
export * from './symbol'
2626
export * from './telemetry'
2727
export * from './textDocument'
28-
export * from './typeDefinitions'
29-
export * from './workspaceFolders'
28+
export * from './typeDefinition'
29+
export * from './workspaceFolder'
3030
export * from './workspace'

src/protocol/initialize.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { NotificationType, RequestType } from '../jsonrpc2/messages'
22
import { URI } from '../types/textDocument'
33
import { ClientCapabilities, ServerCapabilities } from './capabilities'
4-
import { WorkspaceFoldersInitializeParams } from './workspaceFolders'
4+
import { WorkspaceFoldersInitializeParams } from './workspaceFolder'
55

66
/**
77
* The initialize request is sent from the client to the server. It is sent once as the request after starting up
File renamed without changes.
File renamed without changes.
File renamed without changes.

src/protocol/textDocument.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import {
1212
VersionedTextDocumentIdentifier,
1313
} from 'vscode-languageserver-types'
1414
import { NotificationType, RequestType } from '../jsonrpc2/messages'
15-
import { DocumentSelector } from '../types/documents'
15+
import { DocumentSelector } from '../types/document'
1616
/**
1717
* A parameter literal used in requests to pass a text document and a position inside that
1818
* document.
File renamed without changes.
File renamed without changes.
File renamed without changes.

src/types/textDocument.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import * as minimatch from 'minimatch'
22
import { Range, TextDocument } from 'vscode-languageserver-types'
3-
import { DocumentFilter, DocumentSelector } from './documents'
3+
import { DocumentFilter, DocumentSelector } from './document'
44

55
export type URI = string
66

0 commit comments

Comments
 (0)