fix: sanitize first -> validate second, makes sanitizing optional

Author: Rodrigo Solis

examples/contact.js

@@ -52,6 +52,5 @@ function proxyTestDrive(name) {
   }
 }
 proxyTestDrive('Mike');
-//
+proxyTestDrive('   JENNY');
 proxyTestDrive('   MICHAEL');
-// success! { name: 'MICHAEL' };

src/proxy.js

@@ -7,13 +7,21 @@ import type { ProxyFactory } from './types';
 export default function ProxyValidator(schema: Object, sanitizersSchema: Object): ProxyFactory {
   const handler = {
     set(object: Object, prop: string, value: string): boolean {
+      let sanitizedValue = value;
+      if (sanitizersSchema) {
+        const { [prop]: sanitizers } = sanitizersSchema;
+        // save sanitized value for later validation
+        sanitizedValue = applySanitizers(sanitizers, value);
+      }
+
+      // apply validation rules on sanitizedValue
       const { [prop]: rules } = schema;
-      const { success, errors } = checkRules(rules, value);
+      const { success, errors } = checkRules(rules, sanitizedValue);
       if (success) {
-        const { [prop]: sanitizers } = sanitizersSchema;
-        object[prop] = applySanitizers(sanitizers, value);
+        object[prop] = sanitizedValue;
         return success;
       }
+
       throw new ValidationError({ [prop]: errors });
     }
   };

src/validation.js

@@ -5,7 +5,7 @@ import type { ValidationRules, SanitizingRules } from './types';
 
 const GENERIC_ERROR_MESSAGE = 'Invalid input';
 
-export function checkRules(rules: ValidationRules = {}, value: string) {
+export function checkRules(rules: ValidationRules = {}, value: mixed) {
   const errors = [];
   const success = Object.keys(rules)
     .reduce((acc, rule) => {