From ea43d9684b576c794f804c4bc200200b21d216de Mon Sep 17 00:00:00 2001 From: adamw Date: Thu, 17 Aug 2023 09:04:19 +0200 Subject: [PATCH] Move reverse to the accumulator & remove TODO --- core/src/main/scala/sttp/model/headers/AcceptEncoding.scala | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/core/src/main/scala/sttp/model/headers/AcceptEncoding.scala b/core/src/main/scala/sttp/model/headers/AcceptEncoding.scala index 37360c0f..44c4f91b 100644 --- a/core/src/main/scala/sttp/model/headers/AcceptEncoding.scala +++ b/core/src/main/scala/sttp/model/headers/AcceptEncoding.scala @@ -6,7 +6,6 @@ import sttp.model.internal.Validate.RichEither import scala.annotation.tailrec case class AcceptEncoding(encodings: List[WeightedEncoding]) { - override def toString: String = encodings.map(_.toString).mkString(",") } @@ -22,7 +21,7 @@ object AcceptEncoding { else { @tailrec def go(es: List[WeightedEncoding], validated: List[WeightedEncoding]): Either[String, AcceptEncoding] = es match { - case Nil => Right(AcceptEncoding(validated)) + case Nil => Right(AcceptEncoding(validated.reverse)) case head :: tail => validate(head, str) match { case Left(s) => Left(s) @@ -35,7 +34,7 @@ object AcceptEncoding { } private def processString(str: String): List[WeightedEncoding] = - str.trim.split(",").map(x => parsSingleEncoding(x.trim)).reverse.toList // TODO: do we really need `.reverse` here? + str.trim.split(",").map(x => parsSingleEncoding(x.trim)).toList private def parsSingleEncoding(s: String): WeightedEncoding = s.split(";") match {