Update Rust edition to 2024 and use stable rustfmt (#341)

Author: mkaput

.github/workflows/ci.yml

@@ -63,13 +63,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - uses: dtolnay/rust-toolchain@master
-        with:
-          toolchain: nightly-2025-02-01
-          components: rustfmt
       - uses: dtolnay/rust-toolchain@stable
       - uses: Swatinem/rust-cache@v2
-      - run: cargo +nightly-2025-02-01 fmt --check
+      - run: cargo fmt --check
       - run: cargo lint
         env:
           # Make sure CI fails on all warnings, including Clippy lints.

Cargo.toml

@@ -1,7 +1,7 @@
 [package]
 name = "cairo-language-server"
 version = "2.10.0"
-edition = "2021"
+edition = "2024"
 
 authors = ["Software Mansion <contact@swmansion.com>", "StarkWare <info@starkware.co>"]
 description = "The Cairo Language Server"

rustfmt.toml

@@ -1,33 +1,2 @@
-edition = "2021"
-newline_style = "unix"
-use_field_init_shorthand = true
-use_small_heuristics = "Max"
-use_try_shorthand = true
-max_width = 100
-
-# Unstable features below
-unstable_features = true
 style_edition = "2024"
-comment_width = 100
-format_code_in_doc_comments = true
-format_macro_bodies = true
-format_macro_matchers = true
-format_strings = true
-imports_granularity = "Module"
-group_imports = "StdExternalCrate"
-normalize_comments = true
-normalize_doc_attributes = true
-wrap_comments = true
-
-# To use these settings in vscode, add the following line to your settings:
-#     "rust-analyzer.rustfmt.overrideCommand": [
-#         "rustup",
-#         "run",
-#         "nightly-2025-02-01",
-#         "--",
-#         "rustfmt",
-#         "--edition",
-#         "2021",
-#         "--"
-#     ]
-# and run "rustup toolchain install nightly-2025-02-01".
+use_small_heuristics = "Max"

src/lang/proc_macros/plugins/downcast.rs

@@ -14,10 +14,12 @@ use crate::lang::db::AnalysisDatabase;
 /// Safety: This function MUST only be invoked with an object that is of type
 /// [AnalysisDatabase]. Using it with any other type leads to undefined behavior.
 pub(super) unsafe fn unsafe_downcast_ref(db: &dyn SyntaxGroup) -> &AnalysisDatabase {
-    // Replicated logic from `impl dyn Any downcast_ref_unchecked()`.
-    // This approach works as long as `impl dyn Any downcast_ref_unchecked()` implementation is
-    // unchanged and the caller can ensure that `db` is truly an instance of AnalysisDatabase.
-    &*(db as *const dyn SyntaxGroup as *const AnalysisDatabase)
+    unsafe {
+        // Replicated logic from `impl dyn Any downcast_ref_unchecked()`.
+        // This approach works as long as `impl dyn Any downcast_ref_unchecked()` implementation is
+        // unchanged and the caller can ensure that `db` is truly an instance of AnalysisDatabase.
+        &*(db as *const dyn SyntaxGroup as *const AnalysisDatabase)
+    }
 }
 
 #[cfg(test)]

src/project/crate_data.rs

@@ -79,19 +79,17 @@ impl Crate {
             inject_virtual_wrapper_lib(db, crate_id, file_stems);
         }
 
-        let plugins = self.builtin_plugins
+        let plugins = self
+            .builtin_plugins
             .iter()
             .map(BuiltinPlugin::suite)
             .chain(tricks()) // All crates should receive Tricks.
             .chain(enable_linter.then(cairo_lint_plugin_suite))
             .chain(proc_macro_plugin_suite)
-            .fold(
-                get_default_plugin_suite(),
-                |mut acc, suite| {
-                    acc.add(suite);
-                    acc
-                },
-            );
+            .fold(get_default_plugin_suite(), |mut acc, suite| {
+                acc.add(suite);
+                acc
+            });
 
         let interned_plugins = db.intern_plugin_suite(plugins);
         db.set_override_crate_plugins_from_suite(crate_id, interned_plugins);

src/project/manifest_registry/member_config.rs

@@ -23,7 +23,7 @@ impl MemberConfig {
 }
 
 fn merge_serde_json_value(a: &mut Value, b: &Value) {
-    if let (Value::Object(ref mut a_map), Value::Object(ref b_map)) = (a, b) {
+    if let (Value::Object(a_map), Value::Object(b_map)) = (a, b) {
         for (b_key, b_val) in b_map {
             if let Some(a_val) = a_map.get_mut(b_key) {
                 if a_val.is_object() && b_val.is_object() {