Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify documentation for fork() #62

Merged
merged 3 commits into from
Jun 15, 2023
Merged

Clarify documentation for fork() #62

merged 3 commits into from
Jun 15, 2023

Conversation

notgull
Copy link
Member

@notgull notgull commented Jun 10, 2023

Closes #61

@ra1u Does this work for you?

@ra1u
Copy link

ra1u commented Jun 10, 2023

It is much more clear, particularly comment on function.

Related to example, i don't see point of having example with assert_eq! at the end. We would rather have example having assert_ne!. There is also an option to remove example altogether.

@notgull
Copy link
Member Author

notgull commented Jun 11, 2023

How about now? @ra1u

@notgull notgull merged commit 96c01d9 into master Jun 15, 2023
@notgull notgull deleted the notgull/fork-docs branch June 15, 2023 15:19
@notgull notgull mentioned this pull request Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

documentaion on fork() is confusing
2 participants
@notgull @ra1u