Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[awsJson1_x] Content-Encoding tests inconsistent with specification #1827

Closed
Baccata opened this issue Jun 16, 2023 · 2 comments
Closed

[awsJson1_x] Content-Encoding tests inconsistent with specification #1827

Baccata opened this issue Jun 16, 2023 · 2 comments
Assignees

Comments

@Baccata
Copy link

Baccata commented Jun 16, 2023

Hi everyone. My team has noticed that there are tests around compression for the awsJson1_0 and awsJson1_1 protocols that are inconsistent with the specification.

These tests exercise gzip encoding in the context when the user has the possibility of providing a custom encoding via a member of the structure input annotated with @httpHeader("Content-Encoding).

However, the corresponding protocol specification makes it quite clear that http-binding traits must be ignored

Can you elaborate on whether the specification or the test is correct ?

@syall
Copy link
Contributor

syall commented Jun 20, 2023

Hi @Baccata, thanks for catching this issue! The protocol tests are invalid due to the reasons you mentioned, and a PR has been put up to fix them.

@syall
Copy link
Contributor

syall commented Jun 21, 2023

Hi @Baccata , #1831 has been merged, so the protocol test fixes will be available in the next smithy release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants