Add conversions from smithy StatusCode to http StatusCode. #3637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! You'll need to do a few things to be able to have this reviewed and shipped:
|
|
It looks like #3664 bumped the patch version on the crate so there's no need for me to bump it again if they ship together. |
|
You'll need to refresh once more (and bump the crate patch version now as we released yesterday). The CI failures in this PR are due to a transitive dependency issue that was fixed yesterday. |
|
Alright, done. |
|
Rebased again |
aajtodd
approved these changes
Jun 6, 2024
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Making this conversion bidirectional is helpful.
Description
Add
impl From<StatusCode> for httpN::StatusCodethat does the obvious thing.Testing
I'm using these conversions in my own project. As all three crates have identical constraints on the status code value the changes are trivially correct.
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesNot clear to me what if anything to do here.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.