Using defaultsDeep causes that values for array type of parameters are merged with default values
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re merged with default values. Somewhat related to lodash/lodash#2802 (comment)
|
@kasinskim perfect catch. Would you mind considering |
kiebzak
previously approved these changes
May 22, 2018
kiebzak
previously approved these changes
May 22, 2018
kiebzak
approved these changes
May 22, 2018
|
@kiebzak Sounds much simpler :) Thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using
_.defaultsDeepcauses that values forarraytype of parameters are merged with default values which leads to invalid api behaviour.Somewhat related to lodash/lodash#2802 (comment)