Merge pull request #101 from sbellone/fix/normalize-terraform-name

fix: dots are not allowed in Terraform names

Author: sl1pm4t

pkg/tfkschema/name_mapper.go

@@ -100,8 +100,9 @@ func NormalizeTerraformName(s string, toSingular bool, path string) string {
 	}
 	s = strcase.ToSnake(s)
 
-	// colons are not allowed by Terraform
+	// colons and dots are not allowed by Terraform
 	s = strings.ReplaceAll(s, ":", "_")
+	s = strings.ReplaceAll(s, ".", "_")
 
 	return s
 }

pkg/tfkschema/name_mapper_test.go

@@ -252,6 +252,15 @@ func Test_NormalizeTerraformName(t *testing.T) {
 			},
 			"metallb_system_speaker",
 		},
+		{
+			"custom.metrics.k8s.io",
+			args{
+				"custom.metrics.k8s.io",
+				false,
+				"",
+			},
+			"custom_metrics_k_8_s_io",
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {