Refactor file IO into pkg. No functional changes.

Author: Matt Morrison

input_test.go

@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"github.com/hashicorp/hcl/hcl/printer"
 	"github.com/hashicorp/hcl2/hclwrite"
+	"github.com/sl1pm4t/k2tf/pkg/file_io"
 	"github.com/sl1pm4t/k2tf/pkg/tfkschema"
 	flag "github.com/spf13/pflag"
 	"os"
@@ -57,11 +58,11 @@ func main() {
 		Str("builddate", date).
 		Msg("starting k2tf")
 
-	objs := readInput()
+	objs := file_io.ReadInput(input)
 
 	log.Debug().Msgf("read %d objects from input", len(objs))
 
-	w, closer := setupOutput()
+	w, closer := file_io.SetupOutput(output, overwriteExisting)
 	defer closer()
 
 	for i, obj := range objs {

main.go

@@ -1,4 +1,4 @@
-package main
+package file_io
 
 import (
 	"bufio"
@@ -15,14 +15,14 @@ import (
 	"k8s.io/apimachinery/pkg/runtime"
 )
 
-func readInput() []runtime.Object {
+func ReadInput(input string) []runtime.Object {
 	if input == "-" || input == "" {
-		return readStdinInput()
+		return readStdinInput(input)
 	}
-	return readFilesInput()
+	return readFilesInput(input)
 }
 
-func readStdinInput() []runtime.Object {
+func readStdinInput(input string) []runtime.Object {
 	var objs []runtime.Object
 
 	info, err := os.Stdin.Stat()
@@ -63,7 +63,7 @@ func readStdinInput() []runtime.Object {
 	return objs
 }
 
-func readFilesInput() []runtime.Object {
+func readFilesInput(input string) []runtime.Object {
 	var objs []runtime.Object
 
 	if _, err := os.Stat(input); os.IsNotExist(err) {

input.go pkg/file_io/input.go

@@ -0,0 +1,46 @@
+package file_io
+
+import (
+	"testing"
+)
+
+func Test_readFilesInput(t *testing.T) {
+	tests := []struct {
+		name         string
+		input        string
+		wantObjCount int
+	}{
+		{
+			"../../test-fixtures/service.yaml",
+			"../../test-fixtures/service.yaml",
+			1,
+		},
+		{
+			"../../test-fixtures",
+			"../../test-fixtures",
+			25,
+		},
+		{
+			"../../test-fixtures/",
+			"../../test-fixtures/",
+			25,
+		},
+		{
+			"../../test-fixtures/nested/server-clusterrole.yaml",
+			"../../test-fixtures/nested/server-clusterrole.yaml",
+			1,
+		},
+		{
+			"../../test-fixtures/nested/",
+			"../../test-fixtures/nested/",
+			4,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if got := readFilesInput(tt.input); len(got) != tt.wantObjCount {
+				t.Errorf("readFilesInput() object Count = %d, want %d", len(got), tt.wantObjCount)
+			}
+		})
+	}
+}

pkg/file_io/input_test.go

@@ -1,4 +1,4 @@
-package main
+package file_io
 
 import (
 	"io"
@@ -11,7 +11,7 @@ var noOpCloser = func() {}
 
 type CloseFunc func()
 
-func setupOutput() (io.Writer, CloseFunc) {
+func SetupOutput(output string, overwriteExisting bool) (io.Writer, CloseFunc) {
 	var closeFn CloseFunc
 	var w io.Writer