Skip to content

Commit d03ed4d

Browse files
committed
fix(react): no longer use esbuild for bundling
Stencil fixed their stuff so we can just use tsc to build the React bindings
1 parent a9c467a commit d03ed4d

File tree

9 files changed

+67
-343
lines changed

9 files changed

+67
-343
lines changed

package.json

+1-3
Original file line numberDiff line numberDiff line change
@@ -31,23 +31,21 @@
3131
"@typescript-eslint/eslint-plugin": "^5.3.1",
3232
"@typescript-eslint/parser": "^5.3.1",
3333
"cz-conventional-changelog": "^3.3.0",
34-
"esbuild": "^0.13.12",
3534
"eslint": "^8.2.0",
3635
"eslint-config-prettier": "^8.3.0",
3736
"eslint-plugin-import": "^2.25.2",
3837
"eslint-plugin-jsx-a11y": "^6.4.1",
3938
"eslint-plugin-prettier": "^4.0.0",
4039
"eslint-plugin-react": "^7.26.1",
4140
"eslint-plugin-react-hooks": "^4.2.0",
41+
"gen-esm-wrapper": "^1.1.3",
4242
"husky": "^7.0.4",
4343
"lerna": "^4.0.0",
4444
"lint-staged": "^11.2.6",
4545
"prettier": "^2.4.1",
4646
"pretty-quick": "^3.1.1",
4747
"react": "^17.0.2",
4848
"react-dom": "^17.0.2",
49-
"rollup": "^2.59.0",
50-
"rollup-plugin-dts": "^4.0.1",
5149
"typescript": "^4.4.4"
5250
},
5351
"commitlint": {

packages/react/package.json

+7-10
Original file line numberDiff line numberDiff line change
@@ -4,25 +4,21 @@
44
"description": "React bindings for @skyra/discord-components-core",
55
"author": "@skyra",
66
"license": "MIT",
7-
"main": "dist/index.mjs",
7+
"main": "dist/index.js",
88
"module": "dist/index.mjs",
9-
"browser": "dist/index.mjs",
10-
"unpkg": "dist/index.mjs",
119
"typings": "dist/index.d.ts",
1210
"exports": {
1311
"import": "./dist/index.mjs",
14-
"require": "./dist/index.mjs"
12+
"require": "./dist/index.js"
1513
},
1614
"sideEffects": [
17-
"./dist/index.mjs"
15+
"./dist/index.mjs",
16+
"./dist/index.js"
1817
],
1918
"homepage": "https://github.com/skyra-project/discord-components/tree/main/packages/react#readme",
2019
"scripts": {
2120
"clean": "node scripts/clean.mjs",
22-
"build": "yarn clean && yarn build:1 && yarn build:2 && yarn build:3",
23-
"build:1": "node scripts/build.mjs",
24-
"build:2": "tsc -p ./tsconfig.types.json",
25-
"build:3": "rollup -c"
21+
"build": "yarn clean && tsc -p . && gen-esm-wrapper dist/index.js dist/index.mjs"
2622
},
2723
"dependencies": {
2824
"@skyra/discord-components-core": "^2.11.3-alpha.1"
@@ -35,7 +31,8 @@
3531
"lib": "src"
3632
},
3733
"files": [
38-
"dist"
34+
"dist",
35+
"!dist/*.tsbuildinfo"
3936
],
4037
"engines": {
4138
"node": ">=v14.0.0"

packages/react/rollup.config.js

-13
This file was deleted.

packages/react/scripts/build.mjs

-25
This file was deleted.

packages/react/scripts/clean.mjs

+1-3
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
11
import { rm } from 'node:fs/promises';
22

33
const distFolder = new URL('../dist', import.meta.url);
4-
const buildFolder = new URL('../build', import.meta.url);
54

65
const options = { recursive: true, force: true };
76

87
await Promise.all([
9-
rm(distFolder, options), //
10-
rm(buildFolder, options) //
8+
rm(distFolder, options) //
119
]);

packages/react/tsconfig.json

+4-2
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,10 @@
33
"compilerOptions": {
44
"rootDir": "src",
55
"outDir": "dist",
6-
"strictNullChecks": false,
7-
"importsNotUsedAsValues": "remove"
6+
"module": "CommonJS",
7+
"tsBuildInfoFile": "dist/.tsbuildinfo",
8+
"importsNotUsedAsValues": "remove",
9+
"declarationMap": true
810
},
911
"include": ["src"]
1012
}

packages/react/tsconfig.types.json

-9
This file was deleted.

scripts/clean.mjs

+1-3
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ const coreWwwDirectory = new URL('www/', coreDirectory);
99

1010
const reactSrcDirectory = new URL('src/', reactDirectory);
1111
const reactDistDirectory = new URL('dist/', reactDirectory);
12-
const reactBuildDirectory = new URL('build/', reactDirectory);
1312

1413
const options = { recursive: true, force: true };
1514

@@ -18,6 +17,5 @@ await Promise.all([
1817
rm(coreLoaderDirectory, options),
1918
rm(coreWwwDirectory, options),
2019
rm(reactSrcDirectory, options),
21-
rm(reactDistDirectory, options),
22-
rm(reactBuildDirectory, options)
20+
rm(reactDistDirectory, options)
2321
]);

0 commit comments

Comments
 (0)