Skip to content

Commit 8ca07db

Browse files
authored
Merge pull request #16 from skydoves/agp/8.1.2
Bump AGP 8.1.2, Gradle 8.4, and Kotlin 1.9.10
2 parents 7cc2684 + ff5a729 commit 8ca07db

7 files changed

+74
-59
lines changed

app/build.gradle.kts

+39-38
Original file line numberDiff line numberDiff line change
@@ -1,49 +1,50 @@
11
@Suppress("DSL_SCOPE_VIOLATION")
22
plugins {
3-
id(libs.plugins.android.application.get().pluginId)
4-
id(libs.plugins.kotlin.android.get().pluginId)
3+
id(libs.plugins.android.application.get().pluginId)
4+
id(libs.plugins.kotlin.android.get().pluginId)
55
}
66

77
android {
8-
compileSdk = Configuration.compileSdk
9-
10-
defaultConfig {
11-
applicationId = "com.skydoves.whatifdemo"
12-
minSdk = Configuration.minSdk
13-
targetSdk = Configuration.targetSdk
14-
versionCode = Configuration.versionCode
15-
versionName = Configuration.versionName
8+
compileSdk = Configuration.compileSdk
9+
namespace = "com.skydoves.whatifdemo"
10+
11+
defaultConfig {
12+
applicationId = "com.skydoves.whatifdemo"
13+
minSdk = Configuration.minSdk
14+
targetSdk = Configuration.targetSdk
15+
versionCode = Configuration.versionCode
16+
versionName = Configuration.versionName
17+
}
18+
19+
buildFeatures {
20+
compose = true
21+
viewBinding = true
22+
}
23+
24+
composeOptions {
25+
kotlinCompilerExtensionVersion = libs.versions.androidxComposeCompiler.get()
26+
}
27+
28+
packagingOptions {
29+
resources {
30+
excludes.add("/META-INF/{AL2.0,LGPL2.1}")
1631
}
32+
}
1733

18-
buildFeatures {
19-
compose = true
20-
viewBinding = true
21-
}
22-
23-
composeOptions {
24-
kotlinCompilerExtensionVersion = libs.versions.androidxComposeCompiler.get()
25-
}
26-
27-
packagingOptions {
28-
resources {
29-
excludes.add("/META-INF/{AL2.0,LGPL2.1}")
30-
}
31-
}
32-
33-
lint {
34-
abortOnError = false
35-
}
34+
lint {
35+
abortOnError = false
36+
}
3637
}
3738

3839
dependencies {
39-
implementation(project(":whatif"))
40-
implementation(project(":whatif-android"))
41-
42-
implementation(libs.material)
43-
implementation(libs.androidx.activity.compose)
44-
implementation(libs.androidx.compose.ui)
45-
implementation(libs.androidx.compose.material)
46-
implementation(libs.androidx.compose.foundation)
47-
implementation(libs.androidx.compose.runtime)
48-
implementation(libs.landscapist.glide)
40+
implementation(project(":whatif"))
41+
implementation(project(":whatif-android"))
42+
43+
implementation(libs.material)
44+
implementation(libs.androidx.activity.compose)
45+
implementation(libs.androidx.compose.ui)
46+
implementation(libs.androidx.compose.material)
47+
implementation(libs.androidx.compose.foundation)
48+
implementation(libs.androidx.compose.runtime)
49+
implementation(libs.landscapist.glide)
4950
}

gradle/libs.versions.toml

+9-10
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,19 @@
11
[versions]
2-
agp = "7.4.2"
3-
kotlin = "1.8.22"
4-
dokka = "1.8.20"
2+
agp = "8.1.2"
3+
kotlin = "1.9.10"
4+
dokka = "1.9.0"
55
nexusPlugin = "1.3.0"
66
kotlinBinaryCompatibility = "0.13.1"
7-
javaRelease = "8"
87
jvmTarget = "1.8"
9-
material = "1.9.0"
8+
material = "1.10.0"
109
androidxActivity = "1.7.2"
1110
androidxAppCompat = "1.6.1"
12-
androidxCompose = "1.4.3"
13-
androidxComposeCompiler = "1.4.8"
14-
landscapist = "2.2.2"
15-
coroutines = "1.7.1"
11+
androidxCompose = "1.5.3"
12+
androidxComposeCompiler = "1.5.3"
13+
landscapist = "2.2.10"
14+
coroutines = "1.7.3"
1615
retrofit = "2.9.0"
17-
retrofitAdapters = "1.0.6"
16+
retrofitAdapters = "1.0.9"
1817
robolectric = "4.4"
1918
spotless = "6.19.0"
2019

gradle/wrapper/gradle-wrapper.jar

2.02 KB
Binary file not shown.
+2-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.1-all.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-8.4-all.zip
4+
networkTimeout=10000
45
zipStoreBase=GRADLE_USER_HOME
56
zipStorePath=wrapper/dists

gradlew

+14-4
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
# Darwin, MinGW, and NonStop.
5656
#
5757
# (3) This script is generated from the Groovy template
58-
# https://github.com/gradle/gradle/blob/master/subprojects/plugins/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt
58+
# https://github.com/gradle/gradle/blob/HEAD/subprojects/plugins/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt
5959
# within the Gradle project.
6060
#
6161
# You can find Gradle at https://github.com/gradle/gradle/.
@@ -80,10 +80,10 @@ do
8080
esac
8181
done
8282

83-
APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit
84-
85-
APP_NAME="Gradle"
83+
# This is normally unused
84+
# shellcheck disable=SC2034
8685
APP_BASE_NAME=${0##*/}
86+
APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit
8787

8888
# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
8989
DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
@@ -143,12 +143,16 @@ fi
143143
if ! "$cygwin" && ! "$darwin" && ! "$nonstop" ; then
144144
case $MAX_FD in #(
145145
max*)
146+
# In POSIX sh, ulimit -H is undefined. That's why the result is checked to see if it worked.
147+
# shellcheck disable=SC3045
146148
MAX_FD=$( ulimit -H -n ) ||
147149
warn "Could not query maximum file descriptor limit"
148150
esac
149151
case $MAX_FD in #(
150152
'' | soft) :;; #(
151153
*)
154+
# In POSIX sh, ulimit -n is undefined. That's why the result is checked to see if it worked.
155+
# shellcheck disable=SC3045
152156
ulimit -n "$MAX_FD" ||
153157
warn "Could not set maximum file descriptor limit to $MAX_FD"
154158
esac
@@ -205,6 +209,12 @@ set -- \
205209
org.gradle.wrapper.GradleWrapperMain \
206210
"$@"
207211

212+
# Stop when "xargs" is not available.
213+
if ! command -v xargs >/dev/null 2>&1
214+
then
215+
die "xargs is not available"
216+
fi
217+
208218
# Use "xargs" to parse quoted args.
209219
#
210220
# With -n1 it outputs one arg per line, with the quotes and backslashes removed.

gradlew.bat

+9-6
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
@rem limitations under the License.
1515
@rem
1616

17-
@if "%DEBUG%" == "" @echo off
17+
@if "%DEBUG%"=="" @echo off
1818
@rem ##########################################################################
1919
@rem
2020
@rem Gradle startup script for Windows
@@ -25,7 +25,8 @@
2525
if "%OS%"=="Windows_NT" setlocal
2626

2727
set DIRNAME=%~dp0
28-
if "%DIRNAME%" == "" set DIRNAME=.
28+
if "%DIRNAME%"=="" set DIRNAME=.
29+
@rem This is normally unused
2930
set APP_BASE_NAME=%~n0
3031
set APP_HOME=%DIRNAME%
3132

@@ -40,7 +41,7 @@ if defined JAVA_HOME goto findJavaFromJavaHome
4041

4142
set JAVA_EXE=java.exe
4243
%JAVA_EXE% -version >NUL 2>&1
43-
if "%ERRORLEVEL%" == "0" goto execute
44+
if %ERRORLEVEL% equ 0 goto execute
4445

4546
echo.
4647
echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.
@@ -75,13 +76,15 @@ set CLASSPATH=%APP_HOME%\gradle\wrapper\gradle-wrapper.jar
7576

7677
:end
7778
@rem End local scope for the variables with windows NT shell
78-
if "%ERRORLEVEL%"=="0" goto mainEnd
79+
if %ERRORLEVEL% equ 0 goto mainEnd
7980

8081
:fail
8182
rem Set variable GRADLE_EXIT_CONSOLE if you need the _script_ return code instead of
8283
rem the _cmd.exe /c_ return code!
83-
if not "" == "%GRADLE_EXIT_CONSOLE%" exit 1
84-
exit /b 1
84+
set EXIT_CODE=%ERRORLEVEL%
85+
if %EXIT_CODE% equ 0 set EXIT_CODE=1
86+
if not ""=="%GRADLE_EXIT_CONSOLE%" exit %EXIT_CODE%
87+
exit /b %EXIT_CODE%
8588

8689
:mainEnd
8790
if "%OS%"=="Windows_NT" endlocal

whatif-android/build.gradle.kts

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ rootProject.extra.apply {
1414
apply(from ="${rootDir}/scripts/publish-module.gradle")
1515

1616
android {
17+
namespace = "com.skydoves.whatif.android"
1718
compileSdk = Configuration.compileSdk
1819
defaultConfig {
1920
minSdk = Configuration.minSdk

0 commit comments

Comments
 (0)