Skip to content

Commit 0cd2a5a

Browse files
authored
Fix iOS 17 apps hanging just by linking library (🤦‍♂️) (#401)
1 parent 5bb974a commit 0cd2a5a

File tree

5 files changed

+21
-92
lines changed

5 files changed

+21
-92
lines changed

CHANGELOG.md

+8
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,14 @@ Changelog
33

44
## master
55

6+
## [1.1.3]
7+
8+
Due to a mysterious bug on Apple's part that may cause a complete app hang, the unfortunate decision has been made to remove support for `SignInWithAppleButton` introspection.
9+
10+
We apologize for this inconvenience.
11+
12+
More details can be found at https://github.com/siteline/swiftui-introspect/issues/400
13+
614
## [1.1.2]
715

816
- Fixed: "Protocol requirement cannot be declared '@_spi'" (#392)

README.md

-1
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,6 @@ Introspection
117117
- [`.searchable`](https://swiftpackageindex.com/siteline/swiftui-introspect/main/documentation/swiftuiintrospect/searchfieldtype)
118118
- [`SecureField`](https://swiftpackageindex.com/siteline/swiftui-introspect/main/documentation/swiftuiintrospect/securefieldtype)
119119
- [`.sheet`](https://swiftpackageindex.com/siteline/swiftui-introspect/main/documentation/swiftuiintrospect/sheettype)
120-
- [`SignInWithAppleButton`](https://swiftpackageindex.com/siteline/swiftui-introspect/main/documentation/swiftuiintrospect/SignInWithAppleButtonType)
121120
- [`Slider`](https://swiftpackageindex.com/siteline/swiftui-introspect/main/documentation/swiftuiintrospect/slidertype)
122121
- [`Stepper`](https://swiftpackageindex.com/siteline/swiftui-introspect/main/documentation/swiftuiintrospect/steppertype)
123122
- [`Table`](https://swiftpackageindex.com/siteline/swiftui-introspect/main/documentation/swiftuiintrospect/tabletype)

Sources/ViewTypes/SignInWithAppleButton.swift

+13-35
Original file line numberDiff line numberDiff line change
@@ -72,42 +72,20 @@ import SwiftUI
7272
/// ```
7373
public struct SignInWithAppleButtonType: IntrospectableViewType {}
7474

75-
#if canImport(AuthenticationServices)
76-
import AuthenticationServices
77-
7875
extension IntrospectableViewType where Self == SignInWithAppleButtonType {
79-
public static var signInWithAppleButton: Self { .init() }
80-
}
76+
@available(
77+
*,
78+
unavailable,
79+
message: """
80+
Due to a mysterious bug on Apple's part that may cause a complete
81+
app hang, the unfortunate decision has been made to remove support
82+
for `SignInWithAppleButton` introspection.
83+
84+
We apologize for this inconvenience.
8185
82-
extension iOSViewVersion<SignInWithAppleButtonType, ASAuthorizationAppleIDButton> {
83-
@available(*, unavailable, message: "SignInWithAppleButton isn't available on iOS 13")
84-
public static let v13 = Self.unavailable()
85-
public static let v14 = Self(for: .v14)
86-
public static let v15 = Self(for: .v15)
87-
public static let v16 = Self(for: .v16)
88-
public static let v17 = Self(for: .v17)
89-
}
90-
91-
extension tvOSViewVersion<SignInWithAppleButtonType, ASAuthorizationAppleIDButton> {
92-
@available(*, unavailable, message: "SignInWithAppleButton isn't available on tvOS 13")
93-
public static let v13 = Self.unavailable()
94-
public static let v14 = Self(for: .v14)
95-
public static let v15 = Self(for: .v15)
96-
public static let v16 = Self(for: .v16)
97-
public static let v17 = Self(for: .v17)
98-
}
99-
100-
extension macOSViewVersion<SignInWithAppleButtonType, ASAuthorizationAppleIDButton> {
101-
@available(*, unavailable, message: "SignInWithAppleButton isn't available on macOS 10.15")
102-
public static let v10_15 = Self.unavailable()
103-
public static let v11 = Self(for: .v11)
104-
public static let v12 = Self(for: .v12)
105-
public static let v13 = Self(for: .v13)
106-
public static let v14 = Self(for: .v14)
107-
}
108-
109-
extension visionOSViewVersion<SignInWithAppleButtonType, ASAuthorizationAppleIDButton> {
110-
public static let v1 = Self(for: .v1)
86+
More details can be found at https://github.com/siteline/swiftui-introspect/issues/400
87+
"""
88+
)
89+
public static var signInWithAppleButton: Self { .init() }
11190
}
11291
#endif
113-
#endif

Tests/Tests.xcodeproj/project.pbxproj

-6
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,6 @@
116116
D5ADFACC2A4A22AE009494FD /* SheetTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = D5ADFACB2A4A22AE009494FD /* SheetTests.swift */; };
117117
D5ADFACE2A4A3482009494FD /* FullScreenCoverTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = D5ADFACD2A4A3482009494FD /* FullScreenCoverTests.swift */; };
118118
D5ADFAD02A4A3E54009494FD /* PopoverTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = D5ADFACF2A4A3E54009494FD /* PopoverTests.swift */; };
119-
D5ADFAD22A4A41CB009494FD /* SignInWithAppleButtonTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = D5ADFAD12A4A41CB009494FD /* SignInWithAppleButtonTests.swift */; };
120-
D5ADFAD32A4A4649009494FD /* SignInWithAppleButtonTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = D5ADFAD12A4A41CB009494FD /* SignInWithAppleButtonTests.swift */; };
121119
D5ADFAD42A4A4653009494FD /* FullScreenCoverTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = D5ADFACD2A4A3482009494FD /* FullScreenCoverTests.swift */; };
122120
D5ADFAD52A4A4653009494FD /* SheetTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = D5ADFACB2A4A22AE009494FD /* SheetTests.swift */; };
123121
D5ADFAD62A4A4653009494FD /* VideoPlayerTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = D503B2AB2A49BFE300027F5F /* VideoPlayerTests.swift */; };
@@ -223,7 +221,6 @@
223221
D5ADFACB2A4A22AE009494FD /* SheetTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SheetTests.swift; sourceTree = "<group>"; };
224222
D5ADFACD2A4A3482009494FD /* FullScreenCoverTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FullScreenCoverTests.swift; sourceTree = "<group>"; };
225223
D5ADFACF2A4A3E54009494FD /* PopoverTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PopoverTests.swift; sourceTree = "<group>"; };
226-
D5ADFAD12A4A41CB009494FD /* SignInWithAppleButtonTests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SignInWithAppleButtonTests.swift; sourceTree = "<group>"; };
227224
D5AEC33E2A66F31F0015AC1D /* UITestCase.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = UITestCase.swift; sourceTree = "<group>"; };
228225
D5AEC3412A66F6470015AC1D /* RootView.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = RootView.swift; sourceTree = "<group>"; };
229226
D5AEC3422A66F6470015AC1D /* HostingController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = HostingController.swift; sourceTree = "<group>"; };
@@ -399,7 +396,6 @@
399396
D57506A12A281B9C00A628E4 /* SearchFieldTests.swift */,
400397
D57E66F92A6956EB0092F43E /* SecureFieldTests.swift */,
401398
D5ADFACB2A4A22AE009494FD /* SheetTests.swift */,
402-
D5ADFAD12A4A41CB009494FD /* SignInWithAppleButtonTests.swift */,
403399
D58119CF2A23A62C0081F853 /* SliderTests.swift */,
404400
D58119D12A23A77C0081F853 /* StepperTests.swift */,
405401
D575069F2A27FC0400A628E4 /* TableTests.swift */,
@@ -728,7 +724,6 @@
728724
D534D4DD2A4A596200218BFB /* WindowTests.swift in Sources */,
729725
D50E2F662A2B9F6600BAFB03 /* DatePickerWithWheelStyleTests.swift in Sources */,
730726
D50E2F672A2B9F6600BAFB03 /* ListWithInsetGroupedStyleTests.swift in Sources */,
731-
D5ADFAD32A4A4649009494FD /* SignInWithAppleButtonTests.swift in Sources */,
732727
D50E2F682A2B9F6600BAFB03 /* FormWithGroupedStyleTests.swift in Sources */,
733728
D5ADFAD52A4A4653009494FD /* SheetTests.swift in Sources */,
734729
D50E2F692A2B9F6600BAFB03 /* ListWithPlainStyleTests.swift in Sources */,
@@ -839,7 +834,6 @@
839834
D57506882A27CB9800A628E4 /* FormTests.swift in Sources */,
840835
D58119C82A22AC130081F853 /* ToggleTests.swift in Sources */,
841836
D58119D22A23A77C0081F853 /* StepperTests.swift in Sources */,
842-
D5ADFAD22A4A41CB009494FD /* SignInWithAppleButtonTests.swift in Sources */,
843837
D58119DA2A23B7700081F853 /* ColorPickerTests.swift in Sources */,
844838
D575068E2A27D4DC00A628E4 /* ToggleWithButtonStyleTests.swift in Sources */,
845839
D5F0BE6A29C0DC4900AD95AB /* PlatformVersionTests.swift in Sources */,

Tests/Tests/ViewTypes/SignInWithAppleButtonTests.swift

-50
This file was deleted.

0 commit comments

Comments
 (0)