Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

By @slientrob, respect CNAME and README on compile #262

Closed
wants to merge 2 commits into from

Conversation

kennethormandy
Copy link
Collaborator

By @slientrob, harp compile now respects CNAME and the README like it did for .git and .gitignore

@kennethormandy
Copy link
Collaborator Author

@silentrob I’ve added tests for this, but they aren’t passing. I tried compiling a couple of different ways. It seems like the README and the CNAME file still don’t make it through with this update.

@kennethormandy
Copy link
Collaborator Author

Sounds like #312 will help us do this in a more generally applicable way.

@kellydunn
Copy link

@kennethormandy , is there any reason not to merge #312 such that it will solve this issue? Currently, deploying harp as a static site with github pages requires me to manually add CNAME and my README.md back to the project after compilation.

@kennethormandy
Copy link
Collaborator Author

@kellydunn Hey! I would definitely like us merge it in, but it breaks many, many tests right now. I would also like to confirm that we’re not going to mess anything of with Browserify by doing this, but I would be willing to investigate that if someone else wants to tackle getting the tests to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants