Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tower:construction values for man_made=mast and man_made=tower incorrectly assigned (swapped)? #452

Closed
jajajaneeneenee opened this issue May 5, 2024 · 0 comments

Comments

@jajajaneeneenee
Copy link

In this commit you assigned these values for tower:construction to man_made=tower:

<combo key="tower:construction" text="Tower construction" values="freestanding,guyed_lattice,guyed_tube,lattice"
display_values="Freestanding,Guyed lattice,Guyed tube,Lattice" editable="true" match="key" values_searchable="true"/>

And these values to man_made=mast:

<combo key="tower:construction" text="Tower construction" values="dish,dome,freestanding,lattice"
display_values="Dish,Dome,Freestanding,Lattice" editable="true" match="key" values_searchable="true"/>

But doesn't it have to be the other way around? In the wiki, the values ​​lattice/freestanding/dish/dome (and concealed) are listed for man_made=tower and freestanding/guyed_lattice/guyed_tube/lattice for man_made=mast. Which, I think, makes sense.

And by the way: at the end of the item for man_made=mast is a wrong comment: <!-- Tower --> (I saw this also at other items, maybe you could check this in an automated way.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant