Check consistency between persisted snapshots #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous PR added an hourly cronjob to check consistency. This didn't check consistency as expected. After each invocation, a log file is written to disk with the previous checkpoint. Consistency is checked between the previous and current checkpoints. Without persistence, the job would check consistency between the same checkpoints. To implement persistence, we use a GitHub Action that downloads previously uploaded artifacts. Persistence between workflows isn't natively supported. This also changes the persisted format to be a signed checkpoint rather than just the size and root hash, which means we can verify it. This also switches the default URL to be rekor.sigstore.dev, as api was deprecated. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
|
Note there are some TODOs, I'll be creating issues for everything. |
asraa
reviewed
Aug 25, 2022
Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
This was referenced Aug 27, 2022
Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
asraa
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous PR added an hourly cronjob to check consistency. This didn't
check consistency as expected. After each invocation, a log file is
written to disk with the previous checkpoint. Consistency is checked
between the previous and current checkpoints. Without persistence, the
job would check consistency between the same checkpoints.
To implement persistence, we use a GitHub Action that downloads
previously uploaded artifacts. Persistence between workflows isn't
natively supported.
This also changes the persisted format to be a signed checkpoint rather
than just the size and root hash, which means we can verify it.
This also switches the default URL to be rekor.sigstore.dev, as api was
deprecated.
Signed-off-by: Hayden Blauzvern hblauzvern@google.com
Fixes #41
Summary
Release Note
Documentation