forked from oxc-project/oxc
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathrequire_top_level_describe.rs
395 lines (368 loc) · 12.2 KB
/
require_top_level_describe.rs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
use std::collections::HashMap;
use oxc_ast::AstKind;
use oxc_diagnostics::OxcDiagnostic;
use oxc_macros::declare_oxc_lint;
use oxc_semantic::ScopeId;
use oxc_span::Span;
use crate::{
context::LintContext,
rule::Rule,
utils::{
collect_possible_jest_call_node, parse_jest_fn_call, JestFnKind, JestGeneralFnKind,
ParsedGeneralJestFnCall, ParsedJestFnCallNew, PossibleJestNode,
},
};
fn too_many_describes(max: usize, repeat: &str, span0: Span) -> OxcDiagnostic {
OxcDiagnostic::warn("Require test cases and hooks to be inside a `describe` block")
.with_help(format!(
"There should not be more than {max:?} describe{repeat} at the top level."
))
.with_label(span0)
}
fn unexpected_test_case(span0: Span) -> OxcDiagnostic {
OxcDiagnostic::warn("Require test cases and hooks to be inside a `describe` block")
.with_help("All test cases must be wrapped in a describe block.")
.with_label(span0)
}
fn unexpected_hook(span0: Span) -> OxcDiagnostic {
OxcDiagnostic::warn("Require test cases and hooks to be inside a `describe` block")
.with_help("All hooks must be wrapped in a describe block.")
.with_label(span0)
}
#[derive(Debug, Clone)]
pub struct RequireTopLevelDescribe {
pub max_number_of_top_level_describes: usize,
}
impl Default for RequireTopLevelDescribe {
fn default() -> Self {
Self { max_number_of_top_level_describes: usize::MAX }
}
}
declare_oxc_lint!(
/// ### What it does
///
/// This rule triggers a warning if a test case (`test` and `it`) or a hook
/// (`beforeAll`, `beforeEach`, `afterEach`, `afterAll`) is not located in a
/// top-level `describe` block.
///
/// ### Example
///
/// ```javascript
/// // invalid
/// Above a describe block
/// test('my test', () => {});
/// describe('test suite', () => {
/// it('test', () => {});
/// });
/// // Below a describe block
/// describe('test suite', () => {});
/// test('my test', () => {});
/// // Same for hooks
/// beforeAll('my beforeAll', () => {});
/// describe('test suite', () => {});
/// afterEach('my afterEach', () => {});
///
/// //valid
/// // Above a describe block
/// // In a describe block
/// describe('test suite', () => {
/// test('my test', () => {});
/// });
///
/// // In a nested describe block
/// describe('test suite', () => {
/// test('my test', () => {});
/// describe('another test suite', () => {
/// test('my other test', () => {});
/// });
/// });
/// ```
///
/// ### Options
///
/// You can also enforce a limit on the number of describes allowed at the top-level
/// using the `maxNumberOfTopLevelDescribes` option:
///
/// ```json
/// {
/// "jest/require-top-level-describe": [
/// "error",
/// {
/// "maxNumberOfTopLevelDescribes": 2
/// }
/// ]
/// }
/// ```
///
RequireTopLevelDescribe,
style,
);
impl Rule for RequireTopLevelDescribe {
fn from_configuration(value: serde_json::Value) -> Self {
let max_number_of_top_level_describes = value
.get(0)
.and_then(|config| config.get("maxNumberOfTopLevelDescribes"))
.and_then(serde_json::Value::as_number)
.and_then(serde_json::Number::as_u64)
.map_or(usize::MAX, |v| usize::try_from(v).unwrap_or(usize::MAX));
Self { max_number_of_top_level_describes }
}
fn run_once(&self, ctx: &LintContext) {
let mut describe_contexts: HashMap<ScopeId, usize> = HashMap::new();
let mut possibles_jest_nodes = collect_possible_jest_call_node(ctx);
possibles_jest_nodes.sort_by_key(|n| n.node.id());
for possible_jest_node in &possibles_jest_nodes {
self.run(possible_jest_node, &mut describe_contexts, ctx);
}
}
}
impl RequireTopLevelDescribe {
fn run<'a>(
&self,
possible_jest_node: &PossibleJestNode<'a, '_>,
describe_contexts: &mut HashMap<ScopeId, usize>,
ctx: &LintContext<'a>,
) {
let node = possible_jest_node.node;
let scopes = ctx.scopes();
let is_top = scopes.get_flags(node.scope_id()).is_top();
let AstKind::CallExpression(call_expr) = node.kind() else {
return;
};
let Some(ParsedJestFnCallNew::GeneralJest(ParsedGeneralJestFnCall { kind, .. })) =
parse_jest_fn_call(call_expr, possible_jest_node, ctx)
else {
return;
};
match kind {
JestFnKind::General(JestGeneralFnKind::Test) => {
if is_top {
ctx.diagnostic(unexpected_test_case(call_expr.span));
}
}
JestFnKind::General(JestGeneralFnKind::Hook) => {
if is_top {
ctx.diagnostic(unexpected_hook(call_expr.span));
}
}
JestFnKind::General(JestGeneralFnKind::Describe) => {
if !is_top {
return;
}
let Some((_, count)) = describe_contexts.get_key_value(&node.scope_id()) else {
describe_contexts.insert(node.scope_id(), 1);
return;
};
if count >= &self.max_number_of_top_level_describes {
ctx.diagnostic(too_many_describes(
self.max_number_of_top_level_describes,
if *count == 1 { "" } else { "s" },
call_expr.span,
));
} else {
describe_contexts.insert(node.scope_id(), count + 1);
}
}
_ => (),
}
}
}
#[test]
fn test() {
use crate::tester::Tester;
let pass = vec![
("it.each()", None),
("describe(\"test suite\", () => { test(\"my test\") });", None),
("describe(\"test suite\", () => { it(\"my test\") });", None),
(
"
describe(\"test suite\", () => {
beforeEach(\"a\", () => {});
describe(\"b\", () => {});
test(\"c\", () => {})
});
",
None,
),
("describe(\"test suite\", () => { beforeAll(\"my beforeAll\") });", None),
("describe(\"test suite\", () => { afterEach(\"my afterEach\") });", None),
("describe(\"test suite\", () => { afterAll(\"my afterAll\") });", None),
(
"
describe(\"test suite\", () => {
it(\"my test\", () => {})
describe(\"another test suite\", () => {});
test(\"my other test\", () => {})
});
",
None,
),
("foo()", None),
(
"describe.each([1, true])(\"trues\", value => { it(\"an it\", () => expect(value).toBe(true) ); });",
None,
),
(
"
describe('%s', () => {
it('is fine', () => {
//
});
});
describe.each('world')('%s', () => {
it.each([1, 2, 3])('%n', () => {
//
});
});
",
None,
),
(
"
describe.each('hello')('%s', () => {
it('is fine', () => {
//
});
});
describe.each('world')('%s', () => {
it.each([1, 2, 3])('%n', () => {
//
});
});
",
None,
),
(
"
import { jest } from '@jest/globals';
jest.doMock('my-module');
",
None,
),
("jest.doMock(\"my-module\")", None),
("describe(\"test suite\", () => { test(\"my test\") });", None),
("foo()", None),
(
"describe.each([1, true])(\"trues\", value => { it(\"an it\", () => expect(value).toBe(true) ); });",
None,
),
(
"
describe('one', () => {});
describe('two', () => {});
describe('three', () => {});
",
None,
),
(
"
describe('one', () => {
describe('two', () => {});
describe('three', () => {});
});
",
Some(serde_json::json!({ "maxNumberOfTopLevelDescribes": 1 })),
),
];
let fail = vec![
("beforeEach(\"my test\", () => {})", None),
(
"
test(\"my test\", () => {})
describe(\"test suite\", () => {});
",
None,
),
(
"
test(\"my test\", () => {})
describe(\"test suite\", () => {
it(\"test\", () => {})
});
",
None,
),
(
"
describe(\"test suite\", () => {});
afterAll(\"my test\", () => {})
",
None,
),
(
"
import { describe, afterAll as onceEverythingIsDone } from '@jest/globals';
describe(\"test suite\", () => {});
onceEverythingIsDone(\"my test\", () => {})
",
None,
),
("it.skip('test', () => {});", None),
("it.each([1, 2, 3])('%n', () => {});", None),
("it.skip.each([1, 2, 3])('%n', () => {});", None),
("it.skip.each``('%n', () => {});", None),
("it.each``('%n', () => {});", None),
(
"
describe(\"one\", () => {});
describe(\"two\", () => {});
describe(\"three\", () => {});
",
Some(serde_json::json!([{ "maxNumberOfTopLevelDescribes": 2 }])),
),
(
"
describe('one', () => {
describe('one (nested)', () => {});
describe('two (nested)', () => {});
});
describe('two', () => {
describe('one (nested)', () => {});
describe('two (nested)', () => {});
describe('three (nested)', () => {});
});
describe('three', () => {
describe('one (nested)', () => {});
describe('two (nested)', () => {});
describe('three (nested)', () => {});
});
",
Some(serde_json::json!([{ "maxNumberOfTopLevelDescribes": 2 }])),
),
(
"
import {
describe as describe1,
describe as describe2,
describe as describe3,
} from '@jest/globals';
describe1('one', () => {
describe('one (nested)', () => {});
describe('two (nested)', () => {});
});
describe2('two', () => {
describe('one (nested)', () => {});
describe('two (nested)', () => {});
describe('three (nested)', () => {});
});
describe3('three', () => {
describe('one (nested)', () => {});
describe('two (nested)', () => {});
describe('three (nested)', () => {});
});
",
Some(serde_json::json!([{ "maxNumberOfTopLevelDescribes": 2 }])),
),
(
"
describe('one', () => {});
describe('two', () => {});
describe('three', () => {});
",
Some(serde_json::json!([{ "maxNumberOfTopLevelDescribes": 1 }])),
),
];
Tester::new(RequireTopLevelDescribe::NAME, pass, fail)
.with_jest_plugin(true)
.test_and_snapshot();
}