Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLS / Flicker #18

Closed
mdugue opened this issue Jan 5, 2023 · 2 comments · Fixed by #20
Closed

CLS / Flicker #18

mdugue opened this issue Jan 5, 2023 · 2 comments · Fixed by #20
Labels
bug Something isn't working

Comments

@mdugue
Copy link

mdugue commented Jan 5, 2023

Hey, @shuding great library and great idea to target this nitty gritty details in such a nice way 🥳!

Looking carefully at the page load I did realize a little flickering on initial page load. The video below demonstrates it at a slow-motion speed of 10%.

I assume, this comes from transitioning SSR -> client side rendering, where SSR can't apply reasonable balancing. Still, doesn't this break with the claim of not causing layout shifts? Are there a workarounds / ideas on improving that behavior?

ezgif com-gif-maker

@shuding
Copy link
Owner

shuding commented Jan 5, 2023

Thanks, we got some bug reports from Twitter about this too. The layout shift here is caused by a bug related to custom fonts, not because of SSR.

I'm thinking about a fix for this, but the downside is we might have to change the API a bit by adding a <Provider>.

@mdugue
Copy link
Author

mdugue commented Jan 5, 2023

wow, @shuding that was a quick answer and fix 💪👌. Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants