Skip to content

Commit b2ff1e5

Browse files
committed
fix: PR review
1 parent 92dfc89 commit b2ff1e5

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

contracts/dynamic-nft/DevNFTRenderer.sol

+4-5
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import "./NFTRenderer.sol";
88
import "@openzeppelin/contracts/utils/Strings.sol";
99

1010
address payable constant SCHEMA_RESOLVER = payable(0x63FD503800a89280EA1319c7B59E6aa419161aAB);
11-
// address payable constant SCHEMA_RESOLVER = payable(0xEf00E7be55ff65Ad3F8305B042D44b96b05862D8);
1211
address payable constant GITHUB_RESOLVER = payable(0x6455E470f9Ecee5755930c9979b559768BF53170);
1312

1413
contract DevNFTRenderer is NFTRenderer {
@@ -27,12 +26,12 @@ contract DevNFTRenderer is NFTRenderer {
2726
}
2827

2928
function isEligibleToMint(address tokenOwner, string memory repository) public view returns (bool) {
30-
(uint256 totalAttestations,,,) = getAttestationInformations(tokenOwner, repository);
29+
(uint256 totalAttestations,,,) = getAttestationInfo(tokenOwner, repository);
3130
return (totalAttestations > 0);
3231
}
3332

3433
function formatTokenURI(address tokenOwner, string memory nftName, string memory repository, uint256 tokenId) public view returns (string memory) {
35-
(, DevSchemaResolver.AttestationData[] memory attestations,,) = getAttestationInformations(tokenOwner, repository);
34+
(, DevSchemaResolver.AttestationData[] memory attestations,,) = getAttestationInfo(tokenOwner, repository);
3635
string memory contributor = getGithubUsername(tokenOwner);
3736
string memory attributesJson = getAttributes(attestations);
3837
string memory encodedNftName = string(abi.encodePacked(nftName, " #", Strings.toString(tokenId * 1)));
@@ -91,7 +90,7 @@ contract DevNFTRenderer is NFTRenderer {
9190
}
9291

9392

94-
function getAttestationInformations(address tokenOwner, string memory repository)
93+
function getAttestationInfo(address tokenOwner, string memory repository)
9594
private view
9695
returns (uint256, DevSchemaResolver.AttestationData[] memory, uint256, uint256) {
9796
string memory githubUsername = getGithubUsername(tokenOwner);
@@ -102,7 +101,7 @@ contract DevNFTRenderer is NFTRenderer {
102101

103102
function imageURI(address tokenOwner, string memory repository) public view returns(string memory) {
104103
string memory username = getGithubUsername(tokenOwner);
105-
(uint256 prCount, ,uint256 additions, uint256 deletions) = getAttestationInformations(tokenOwner, repository);
104+
(uint256 prCount, ,uint256 additions, uint256 deletions) = getAttestationInfo(tokenOwner, repository);
106105

107106
string memory background = generateBackground(prCount);
108107
string memory avatar = generateAvatar(prCount);

0 commit comments

Comments
 (0)