- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: v1.0.0 - API breaking changes #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shortcuts
added a commit
that referenced
this pull request
Mar 4, 2023
🤖 I have created a release *beep* *boop* --- ## [1.0.0](v0.10.2...v1.0.0) (2023-03-04) ### ⚠ BREAKING CHANGES * v1.0.0 - API breaking changes ([#201](#201)) ### Features * v1.0.0 - API breaking changes ([#201](#201)) ([2b6cb3c](2b6cb3c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: shortcuts <vannicattec@gmail.com>
krmbzds
added a commit
to krmbzds/nvim
that referenced
this pull request
Mar 5, 2023
krmbzds
added a commit
to krmbzds/nvim
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📃 Summary
This PR introduces the v1.0.0 of the plugin, which comes with several breaking changes at the API level.
The plugin evolved fast but some part of the API are not extensible enough to continue the iteration, this much needed breaking change allow future features to be added without having to break the it again.
Breaking changes
enableOnVimEnter
autocmds.enableOnVimEnter
enableOnTabEnter
autocmds.enableOnTabEnter
toggleMapping
mappings.toggle
widthUpMapping
mappings.widthUp
widthDownMapping
mappings.widthDown
backgroundColor
colors.background
textColor
colors.text
blend
colors.blend
left.backgroundColor
left.colors.background
left.textColor
left.colors.text
left.blend
left.colors.blend
right.backgroundColor
right.colors.background
right.textColor
right.colors.text
right.blend
right.colors.blend
mappings
under a dedicated objectmappings
by default to prevent impacting other users workflowenabled
colors
under a dedicated objectautocmds
under a dedicated object