fix: Do not make LICENSE_REQUEST_FAILED fatal if other keys are successful #6457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
|
@caridley can you try it in your local and see if this resolves your issue? I have tried your stream and it works, but I want to double check... |
|
I will test this on our streams by end of day Monday |
|
Incremental code coverage: 52.94% |
joeyparrish
changed the title
joeyparrish
approved these changes
Apr 19, 2024
|
@caridley I look forward to your results, I hope we can merge this today :) |
|
I tried it again and your content works. So I guess your tests went well. |
joeyparrish
pushed a commit
that referenced
this pull request
May 7, 2024
joeyparrish
pushed a commit
that referenced
this pull request
May 7, 2024
joeyparrish
pushed a commit
that referenced
this pull request
May 7, 2024
joeyparrish
pushed a commit
that referenced
this pull request
May 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3051