Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: Fix potential AV sync issues after seek or adaptation #6435

Merged
merged 1 commit into from
Apr 11, 2024
Merged

revert: Fix potential AV sync issues after seek or adaptation #6435

merged 1 commit into from
Apr 11, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Apr 10, 2024 •
edited by theodab
Loading

This reverts #4886, which was found to cause issues with fetching segments after seeking.

Closes #5785
Re-open #4589

@avelad avelad added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release labels Apr 10, 2024
@avelad avelad added this to the v5.0 milestone Apr 10, 2024
@avelad avelad requested review from joeyparrish and theodab April 10, 2024 13:24
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

theodab
theodab reviewed Apr 11, 2024
View reviewed changes
Copy link
Contributor

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is a reversion of #4886, correct? Except for a few typos that PR fixed, which have no reason to be reverted, of course.

Would you say that #4589 is now no longer a problem even without the fix? If not, we will want to re-open that issue. Luckily, it seems like the sample content for that issue still exists.

@theodab theodab changed the title fix(HLS): Fix new segments are not fetched after seeking revert: Fix potential AV sync issues after seek or adaptation Apr 11, 2024
@theodab theodab merged commit 73117f0 into shaka-project:main Apr 11, 2024
21 of 22 checks passed
@shaka-bot shaka-bot mentioned this pull request Apr 11, 2024
Merged
@avelad avelad deleted the hls-fix-segments-not-fetched branch April 11, 2024 06:26
@theodab theodab mentioned this pull request Apr 11, 2024
Closed
avelad added a commit that referenced this pull request Apr 15, 2024
@avelad
revert: Fix potential AV sync issues after seek or adaptation (#6435)
3a231dd 
This reverts #4886, which was found to cause issues with fetching segments after seeking.

Closes #5785
Re-open #4589
@shaka-bot shaka-bot mentioned this pull request Apr 10, 2024
Merged
avelad added a commit that referenced this pull request Apr 15, 2024
@avelad
revert: Fix potential AV sync issues after seek or adaptation (#6435)
cbbb704 
This reverts #4886, which was found to cause issues with fetching segments after seeking.

Closes #5785
Re-open #4589
@shaka-bot shaka-bot mentioned this pull request Apr 10, 2024
Merged
joeyparrish pushed a commit that referenced this pull request May 7, 2024
@avelad @joeyparrish
revert: Fix potential AV sync issues after seek or adaptation (#6435)
78590ca 
This reverts #4886, which was found to cause issues with fetching segments after seeking.

Closes #5785
Re-open #4589
joeyparrish pushed a commit that referenced this pull request May 7, 2024
@avelad @joeyparrish
revert: Fix potential AV sync issues after seek or adaptation (#6435)
c3ce673 
This reverts #4886, which was found to cause issues with fetching segments after seeking.

Closes #5785
Re-open #4589
@shaka-bot shaka-bot mentioned this pull request May 7, 2024
Merged
@TommiRautanen
Copy link

@avelad was the issue with fetching segments after seeking related to VOD, LIVE or both? I don't think we experienced fetching segments issue in our LIVE streams so in case it was an issue restricted to VODs only, any chance original fix could be applied to LIVE streams?

@TommiRautanen
Copy link

@joeyparrish can you comment on the above?

@avelad
Copy link
Member Author

avelad commented May 21, 2024

This was generic, so it affects both VOD and Live.

@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jun 10, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.

Regression: New segments are not fetched after seeking until the player is out of buffer
4 participants
@avelad @shaka-bot @TommiRautanen @theodab