fix: Fix detection of flac support on Safari #6250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyparrish
approved these changes
Feb 16, 2024
|
The CI didn't run on this PR automatically because it's your first on the project. Once I check the test results, I'll merge it. Thanks for your contribution! |
joeyparrish
changed the title
joeyparrish
added
type: bug
|
Incremental code coverage: 100.00% |
joeyparrish
pushed a commit
that referenced
this pull request
Feb 17, 2024
When constructing the MediaDecodingConfigurations to query media capabilities in `stream_utils.js`, the spelling of "fLaC" should not change to "flac" on Safari. This is because on Safari the query will return `supported: false` for "flac" but `supported: true` for "fLaC". This change allows manifests with "fLaC" codecs to work properly on Safari when using MSE / Managed Media Source. Fixes #6249 Backported to v4.3.x
joeyparrish
pushed a commit
that referenced
this pull request
Feb 20, 2024
When constructing the MediaDecodingConfigurations to query media capabilities in `stream_utils.js`, the spelling of "fLaC" should not change to "flac" on Safari. This is because on Safari the query will return `supported: false` for "flac" but `supported: true` for "fLaC". This change allows manifests with "fLaC" codecs to work properly on Safari when using MSE / Managed Media Source. Fixes #6249
joeyparrish
pushed a commit
that referenced
this pull request
Feb 20, 2024
When constructing the MediaDecodingConfigurations to query media capabilities in `stream_utils.js`, the spelling of "fLaC" should not change to "flac" on Safari. This is because on Safari the query will return `supported: false` for "flac" but `supported: true` for "fLaC". This change allows manifests with "fLaC" codecs to work properly on Safari when using MSE / Managed Media Source. Fixes #6249
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When constructing the MediaDecodingConfigurations to query media capabilities in
stream_utils.js, the spelling of "fLaC" should not change to "flac" on Safari. This is because on Safari the query will returnsupported: falsefor "flac" butsupported: truefor "fLaC".This change allows manifests with "fLaC" codecs to work properly on Safari when using MSE / Managed Media Source.
Fixes #6249