Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffering spinner not visible against a black background #2110

Closed
joeyparrish opened this issue Aug 21, 2019 · 2 comments
Closed

Buffering spinner not visible against a black background #2110

joeyparrish opened this issue Aug 21, 2019 · 2 comments
Assignees
Labels
component: UI The issue involves the Shaka Player UI status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@joeyparrish
Copy link
Member

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
master

Can you reproduce the issue with our latest release version?

Can you reproduce the issue with the latest code from master?
Yes

Are you using the demo app or your own custom app?
Demo

What browser and OS are you using?
ChromeOS stable

What are the manifest and license server URIs?
https://nightly-dot-shaka-player-demo.appspot.com/demo/#audiolang=de;textlang=de;uilang=de;asset=https://storage.googleapis.com/shaka-live-assets/player-source.m3u8;panel=HOME;build=uncompiled

What did you do?
This live stream is currently down, so it will play the last several seconds, then buffer forever.

What did you expect to happen?
When the player enters a buffering state, I would expect to be able to see the spinner against any background.

What actually happened?
The spinner is black, and the video frame is mostly black, so it is very hard to see. If the controls are shown, it is even harder to see against the outline of the pause button.

It might be nice if there were a white shadow around the black spinner. Not sure if Chrome native controls are any better in this regard. I haven't tested that.

@joeyparrish joeyparrish added type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI labels Aug 21, 2019
@shaka-bot shaka-bot added this to the v2.6 milestone Aug 21, 2019
@joeyparrish
Copy link
Member Author

Adding filter: drop-shadow(0 0 5px white) on the spinner container in the debugger looks pretty decent. Not sure if 5px is a bad idea, though. Perhaps some relative unit would make more sense, but I'm not sure what.

@ismena
Copy link
Contributor

ismena commented Aug 23, 2019

I... um... don't like the way that filter looks very much 😶

I checked what the Native controls do, and their spinner is even more black than hours, I can't see it at all.
Will keep thinking :|

@shaka-project shaka-project locked and limited conversation to collaborators Oct 22, 2019
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: UI The issue involves the Shaka Player UI status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

3 participants