Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cant compile shaka-player #1700

Closed
Kogoruhn opened this issue Nov 26, 2018 · 5 comments
Closed

Cant compile shaka-player #1700

Kogoruhn opened this issue Nov 26, 2018 · 5 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@Kogoruhn
Copy link

Have you read the FAQ and checked for duplicate open issues?:
Yes
What version of Shaka Player are you using?:
2.5.0-beta2
Can you reproduce the issue with our latest release version?:
Yup
Can you reproduce the issue with the latest code from master?:
Are you using the demo app or your own custom app?:
not applicable
If custom app, can you reproduce the issue using our demo app?:
What browser and OS are you using?:
Windows 7 Professional
What are the manifest and license server URIs?:
not applicable
What did you do?
try to compile shaka according to https://shaka-player-demo.appspot.com/docs/api/tutorial-welcome.html
What did you expect to happen?
shaka compiled
What actually happened?
error during compilation, in /dist presents only deps.js, .lintstamp, .htmllintstamp

I use standard cmd with administrator rights. About a month ago compilation was OK.

image_2018-11-26_18-32-25

@TheModMaker TheModMaker added type: bug Something isn't working correctly and removed needs triage labels Nov 26, 2018
@TheModMaker TheModMaker added this to the v2.5 milestone Nov 26, 2018
@TheModMaker TheModMaker self-assigned this Nov 26, 2018
@TheModMaker
Copy link
Contributor

It looks like it is a problem with how we create paths in Windows. But you should not run this with administrator rights.

@Kogoruhn
Copy link
Author

Kogoruhn commented Nov 26, 2018

Honestly, I've tried to compile both - with & w/o adm. rights, got same result... Thanks for response!

@Kogoruhn
Copy link
Author

Kogoruhn commented Dec 4, 2018

YAY! Shaka compiled! @TheModMaker U were right!

build/shakaBuildHelpers.py:

def get_source_base():
  """Returns the absolute path to the source code base."""
  source_base = os.path.abspath(os.path.join(os.path.dirname(__file__), '..'))
  # In the build files, we use '/' in the paths, however Windows uses '\'.
  # Although Windows supports both, the source mapping will not work with '\'.
  # So we use Linux-style paths for everything.
  return source_base.replace('\\', '/')

set return source_base. Thats it. And for pass the check in compiler.by

assert source_base[-1] == '\\', 'Source base format changed!'

@joeyparrish
Copy link
Member

@Kogoruhn, thanks for the feedback! Please confirm with the change we just released so that we know the official fix works for you, as well.

@Kogoruhn
Copy link
Author

Kogoruhn commented Dec 5, 2018

@joeyparrish
shaka2

Same error that was in my "repair"...

in /dist: shaka-player.compiled.debug.js, shaka-player.ui.debug.js (+ .map, .externs)
But anyway, now i got what i want:)

@shaka-project shaka-project locked and limited conversation to collaborators Feb 2, 2019
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

4 participants