Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend shaka.util.LicenseRequest method be configurable. #134

Closed
chemoish opened this issue Jul 22, 2015 · 1 comment
Closed

Recommend shaka.util.LicenseRequest method be configurable. #134

chemoish opened this issue Jul 22, 2015 · 1 comment
Labels
flag: good first issue This might be a relatively easy issue; good for new contributors status: archived Archived and locked; will not be updated type: enhancement New feature or request

Comments

@chemoish
Copy link

I am executing the following code and the license_server I am using only accepts method: "GET".

var license_server = ...

return new shaka.player.DrmSchemeInfo(
    'com.widevine.alpha',
    license_server,
    false, /* withCredentials */
    null, /* licensePostProcessor */
    null /* licensePreProcessor */
);

Can we please allow shaka.player.DrmSchemeInfo be configurable to handle such case?


https://github.com/google/shaka-player/blob/master/lib/util/license_request.js#L44

// please update me
this.parameters.method = 'POST';
@tdrews tdrews added type: enhancement New feature or request flag: good first issue This might be a relatively easy issue; good for new contributors labels Jul 23, 2015
@tdrews
Copy link
Contributor

tdrews commented Jul 23, 2015

We can add an HTTP method override to the licenseRequestInfo object.

@tdrews tdrews self-assigned this Jul 23, 2015
@tdrews tdrews closed this as completed in 8880a8e Jul 27, 2015
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
flag: good first issue This might be a relatively easy issue; good for new contributors status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants