feat: Add a toggle between hex and base64 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beback4u
reviewed
Apr 6, 2023
There was a problem hiding this comment.
You will follow the release process: go/eme-logger-formatter-release.
- Do integration tests before landing this change. See Test by developer section.
- Update after landing this change. Find the test tracker link from Test trackers section. Add new test steps for hex<->base64 toggle for "1.1.1 - EME Logger Function Tests".
- Follow the publishing process for EME Logger. Note that the
release-pleasebranch by automated release tool will pick your change up once landed, I think.
beback4u
reviewed
Apr 11, 2023
gvking
pushed a commit
that referenced
this pull request
Apr 11, 2023
🤖 I have created a release *beep* *boop* --- ## [3.4.0](v3.3.0...v3.4.0) (2023-04-11) ### Features * Add a toggle between hex and base64 ([#62](#62)) ([7fa1a98](7fa1a98)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot less rewrite -> same feature of toggle. Also makes use of session storage instead of chrome storage so we don't request extra permissions from the users, and is more lightweight and easier to access.