Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrimeRadioButton issue #37

Closed
csakis opened this issue Mar 11, 2024 · 4 comments
Closed

PrimeRadioButton issue #37

csakis opened this issue Mar 11, 2024 · 4 comments

Comments

@csakis
Copy link

csakis commented Mar 11, 2024

Something is fishy with the radio buttons.
There are two custom class fields: options_class and option_class.
As far as I can see options_class works as it is supposed to, however, option_class doesn't. It's not defined in the FormKitPrimeRadioButtonProps.
If I look at the RadioButtons Example website: https://formkit-primevue.netlify.app/inputs/radioButton, the radiobuttons
are rendered this way:
image

There's a div with an empty class and a div under it with option_class attribute.
Is this intended behavior?

I am trying to have my radiobuttons in a row and align the labels and the buttons vertically centered with flex box, and I am not able to do it because of the wrapper div with the empty class, I don;t know how to target that div to not have an empty class.

@sfxcode
Copy link
Owner

sfxcode commented Mar 11, 2024

You are right - option_class was not rendered .... should be fixed in 1.9.3

Please check the latest version if it solves your problem.

Greetings,

Tom

@csakis
Copy link
Author

csakis commented Mar 11, 2024

@sfxcode Thank you for the quick fix. It's getting better. I have also just noticed that you added the p-formkit-radio-label hard-coded class to the label component of the RadioButton in release 1.9.0. Was there any reason to do so? Also , it would be nice to be able to customize the label with custom classes.

sfxcode added a commit that referenced this issue Mar 13, 2024
sfxcode added a commit that referenced this issue Mar 13, 2024
@sfxcode
Copy link
Owner

sfxcode commented Mar 13, 2024

Hi,

added new label_class property. Feel free to try it out together with latest input: InputOtp ;-)

Nice coding time,

Tom

@csakis
Copy link
Author

csakis commented Mar 13, 2024

Thank you

@csakis csakis closed this as completed Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants