Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin SFS-Python version #32

Open
mgeier opened this issue Mar 11, 2019 · 3 comments
Open

Pin SFS-Python version #32

mgeier opened this issue Mar 11, 2019 · 3 comments

Comments

@mgeier
Copy link
Member

mgeier commented Mar 11, 2019

Currently, only sfs is required.

Since the API of SFS-Python is likely to change from time to time, it would be good to require a specific version to make sure all code examples actually work.

@hagenw
Copy link
Member

hagenw commented Mar 12, 2019

Good point, I will adjust this before the DAGA. I just have to check if I want to go with sfs 0.4 or 0.5

@mgeier
Copy link
Member Author

mgeier commented Mar 13, 2019

You could start by pinning sfs==0.4.* now, because without that, the build will break with the upcoming release of SFS 0.5.0.

At some later point, you could update the code examples and change the required version to sfs==0.5.*.

@hagenw
Copy link
Member

hagenw commented Mar 14, 2019

I updated the API to the upcoming sfs and pinned the version to sfs>=0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants