Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgres-protocol v0.3.1 was a breaking change and should be yanked #290

Closed
golddranks opened this issue Sep 13, 2017 · 2 comments
Closed

Comments

@golddranks
Copy link

postgres-protocol v0.3.1 includes a bump from generic-array v0.7 to generic-array v0.8. I don't know why, but having different major versions of generic-array in the same build generally breaks it, even if it isn't exposed in the public API. Therefore the 0.3.1 bump was a breaking change for anybody that is using a crate that depends on generic-array v0.7.

Btw. I've seen breakage with generic-array before, and I'd greatly appreciate if somebody helped me understand why it induces breaking changes.

0.3.1 should be yanked, and 0.4 released instead.

@sfackler
Copy link
Owner

generic-array 0.7 depended on typenum ~1.5 rather than the more normal 1.5 (i.e. ^1.5). This means it claims it can't work with typenum 1.7 even though they are semver compatible. generic-array 0.8 now has a fixed version constraint but 0.7 doesn't.

@fizyk20 can you make one final 0.7 release to fix things up when depending on both versions?

@sfackler
Copy link
Owner

A fixed version of generic-array 0.7 has been published so this should be resolved - please reopen if not!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants