Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to bitflags 0.5. #10077

Closed
Ms2ger opened this issue Mar 18, 2016 · 6 comments
Closed

Update to bitflags 0.5. #10077

Ms2ger opened this issue Mar 18, 2016 · 6 comments
Labels
A-build Related to or part of the build process I-cleanup No impact; the issue is one of maintainability or tidiness.

Comments

@Ms2ger
Copy link
Contributor

Ms2ger commented Mar 18, 2016

And remove it from the list of exceptions in python/tidy.py, to which I added it in #10076.
@saurvs
Copy link
Contributor

saurvs commented Mar 23, 2016

I'd like to do this.

@Ms2ger
Copy link
Contributor Author

Ms2ger commented Mar 23, 2016

Go for it. I'd suggest you comment here with to the PRs you create on other repositories.

@saurvs
Copy link
Contributor

saurvs commented Mar 23, 2016

Just to clarify, every Rust repo part of the Servo org needs to use the new version of bitflags?

@Ms2ger
Copy link
Contributor Author

Ms2ger commented Mar 23, 2016

Each crate that we depend on, here's a list:

./ports/geckolib/Cargo.lock:1: 
Version 0.3.3:
        selectors
        style
        util

./ports/geckolib/Cargo.lock:1: 
Version 0.4.0:
        geckoservo

./ports/gonk/Cargo.lock:1: 
Version 0.3.3:
        cocoa
        devtools_traits
        gfx
        layout
        msg
        png
        script
        selectors
        servo
        style
        util
        wayland-client
        wayland-kbd
        websocket
        xml-rs

./ports/gonk/Cargo.lock:1: 
Version 0.4.0:
        openssl

./components/servo/Cargo.lock:1: 
Version 0.3.3:
        servo
        cocoa
        devtools_traits
        gfx
        layout
        msg
        png
        script
        selectors
        style
        util
        wayland-client
        wayland-kbd
        websocket
        xml-rs

./components/servo/Cargo.lock:1: 
Version 0.4.0:
        glutin_app
        openssl

@saurvs
Copy link
Contributor

saurvs commented Mar 23, 2016

Alright.

This was referenced Mar 23, 2016
Closed
Merged
Closed
Closed
bors-servo pushed a commit to servo/rust-selectors that referenced this issue Apr 2, 2016
Auto merge of #77 - saurvs:master, r=SimonSapin
ec406f1 
Use bitflags 0.5

Part of servo/servo#10077

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-selectors/77)
<!-- Reviewable:end -->
This was referenced Apr 4, 2016
Closed
Closed
@mbrubeck mbrubeck added A-build Related to or part of the build process I-cleanup No impact; the issue is one of maintainability or tidiness. labels May 23, 2016
@mbrubeck
Copy link
Contributor

Fixed by #11191.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-build Related to or part of the build process I-cleanup No impact; the issue is one of maintainability or tidiness.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mbrubeck @Ms2ger @saurvs