Skip to content
This repository was archived by the owner on Apr 10, 2024. It is now read-only.

Commit ad72caa

Browse files
committed
Only add network aliases for the default network
1 parent 693134b commit ad72caa

File tree

5 files changed

+17
-10
lines changed

5 files changed

+17
-10
lines changed

CHANGELOG.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,17 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8-
## [Unreleased]
8+
## [0.2.1] - 2024-01-02
99

10-
### Changed
10+
### Fixed
1111

12-
- Upgrade dependencies
12+
- Only add network aliases for the default network.
1313

1414
## [0.2.0] - 2023-08-05
1515

1616
### Changed
1717

18-
- Upgrade dependencies
18+
- Upgrade dependencies.
1919

2020
### Fixed
2121

Cargo.lock

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "haddock"
3-
version = "0.2.0"
3+
version = "0.2.1"
44
edition = "2021"
55
description = "Docker Compose for Podman"
66
repository = "https://github.com/seowalex/haddock"
@@ -55,5 +55,6 @@ enum_variant_names = "allow"
5555
large_enum_variant = "allow"
5656
needless_pass_by_value = "allow"
5757
struct_excessive_bools = "allow"
58+
struct_field_names = "allow"
5859
too_many_lines = "allow"
5960
unnecessary_wraps = "allow"

src/commands/create.rs

+5-2
Original file line numberDiff line numberDiff line change
@@ -446,8 +446,6 @@ async fn create_containers(
446446
project_name,
447447
"--name",
448448
&container_name,
449-
"--network-alias",
450-
service_name,
451449
])
452450
.chain(requirements.iter().flat_map(|requirement| {
453451
["--requires", requirement]
@@ -470,6 +468,11 @@ async fn create_containers(
470468
.iter()
471469
.flat_map(|network| ["--network", network]),
472470
)
471+
.chain(if service.networks.contains_key("default") {
472+
vec!["--network-alias", service_name]
473+
} else {
474+
vec![]
475+
})
473476
.chain(volumes.iter().map(AsRef::as_ref))
474477
.chain(
475478
secrets

src/commands/run.rs

+5-2
Original file line numberDiff line numberDiff line change
@@ -201,8 +201,6 @@ async fn run_container(
201201
project_name,
202202
"--name",
203203
&container_name,
204-
"--network-alias",
205-
&args.service,
206204
])
207205
.chain(
208206
requirements
@@ -216,6 +214,11 @@ async fn run_container(
216214
vec![]
217215
})
218216
.chain(networks.iter().flat_map(|network| ["--network", network]))
217+
.chain(if service.networks.contains_key("default") {
218+
vec!["--network-alias", &args.service]
219+
} else {
220+
vec![]
221+
})
219222
.chain(volumes.iter().map(AsRef::as_ref))
220223
.chain(secrets.iter().flat_map(|secret| ["--secret", secret]))
221224
.chain(if args.detach {

0 commit comments

Comments
 (0)