Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL Encoding for C#, F#, and Other Language with Special Characters #20

Open
wmboyles opened this issue Feb 1, 2023 · 0 comments
Open

Comments

@wmboyles
Copy link

wmboyles commented Feb 1, 2023

When one tries to go toGET /language/C#, they very reasonably get sent to results for the C programming language. This is because the hash in URL encoding is a segment identifier. If one instead correctly encodes the hash (or sharp), going to GET /language/C%23, they are correctly given results for the C# programming language. However, for the same encoding reason I described above, the results will show 404's.

For example, consider one of the URLs returned by the API,

https://raw.githubusercontent.com/cat-milk/Anime-Girls-Holding-Programming-Books/master/C#/Chisaki_Tapris_C#.png

Using this link directly will result in a 404. However, if one changes the #'s to their expected URL encoding,

https://raw.githubusercontent.com/cat-milk/Anime-Girls-Holding-Programming-Books/master/C%23/Chisaki_Tapris_C%23.png

The image is found. This change would enable the senpy.club page for C# to actually show images.

Note the same problem is present for F#. A similar issue is also present for C++. However, it is more subtle because most of the images load correctly. However, when one clicks on a certain image, they are instead redirected to an image for the C language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant