Skip to content

Commit

Permalink
Pass options to RemoteWebDriver (#9240)
Browse files Browse the repository at this point in the history
I believe that was the original intention of code in c23e440 - it updates or creates the options object, but it doesn't use it later.

This reverts #9208 and passes options to the super class.

Co-authored-by: David Burns <david.burns@theautomatedtester.co.uk>
  • Loading branch information
nijel and AutomatedTester authored Mar 10, 2021
1 parent 23d51da commit c02a2d0
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions py/selenium/webdriver/chromium/webdriver.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,6 @@ def __init__(self, browser_name, vendor_prefix,
if desired_capabilities:
for key, value in desired_capabilities.items():
options.set_capability(key, value)
else:
desired_capabilities = options.to_capabilities()

if options._ignore_local_proxy:
_ignore_proxy = options._ignore_local_proxy
Expand All @@ -96,7 +94,8 @@ def __init__(self, browser_name, vendor_prefix,
remote_server_addr=self.service.service_url,
browser_name=browser_name, vendor_prefix=vendor_prefix,
keep_alive=keep_alive, ignore_proxy=_ignore_proxy),
desired_capabilities=desired_capabilities)
desired_capabilities=desired_capabilities,
options=options)
except Exception:
self.quit()
raise
Expand Down

0 comments on commit c02a2d0

Please sign in to comment.